You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/14 04:34:44 UTC

[GitHub] [pulsar] aloyszhang commented on a change in pull request #13679: Support dynamic update cache config

aloyszhang commented on a change in pull request #13679:
URL: https://github.com/apache/pulsar/pull/13679#discussion_r825586575



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerFactory.java
##########
@@ -179,4 +180,22 @@ void asyncOpenReadOnlyCursor(String managedLedgerName, Position startPosition, M
      */
     CompletableFuture<Boolean> asyncExists(String ledgerName);
 
+    /**
+     * @return return EntryCacheManager.
+     */
+    EntryCacheManager getEntryCacheManager();
+
+    /**
+     * update cache size and evictionTriggerThreshold.
+     *
+     * @param maxSize max cache size.
+     */
+    void updateCacheSizeAndThreshold(long maxSize);

Review comment:
       It's better to update `cacheSize` and `threahold` directly to `EntryCacheManager` to keep consistence to `managedLedgerCacheEvictionWatermark`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org