You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by bananer <gi...@git.apache.org> on 2018/03/07 19:53:40 UTC
[GitHub] thrift pull request #1502: THRIFT-4509: update grunt to 1.0.2
GitHub user bananer opened a pull request:
https://github.com/apache/thrift/pull/1502
THRIFT-4509: update grunt to 1.0.2
switch from grunt-external-daemon and grunt-shell to grunt-shell-spawn and update grunt to 1.0.2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bananer/thrift THRIFT-4509-update-grunt
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1502.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1502
----
commit f4df106c25089a1ba3a39d39a9fd0e620234a74b
Author: Philip Frank <ic...@...>
Date: 2018-03-07T19:49:25Z
THRIFT-4509: switch from grunt-external-daemon and grunt-shell to grunt-shell-spawn and update grunt to 1.0.2
----
---
[GitHub] thrift pull request #1502: THRIFT-4509: update grunt to 1.0.2
Posted by bananer <gi...@git.apache.org>.
Github user bananer closed the pull request at:
https://github.com/apache/thrift/pull/1502
---
[GitHub] thrift issue #1502: THRIFT-4509: update grunt to 1.0.2
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1502
In the future you can squash, rebase, and force push to keep the same PR, see:
https://thrift.apache.org/docs/HowToContribute
---
[GitHub] thrift issue #1502: THRIFT-4509: update grunt to 1.0.2
Posted by bananer <gi...@git.apache.org>.
Github user bananer commented on the issue:
https://github.com/apache/thrift/pull/1502
Rebased as https://github.com/apache/thrift/pull/1506
---
[GitHub] thrift issue #1502: THRIFT-4509: update grunt to 1.0.2
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1502
Any special considerations we need to add to the README for js or nodejs if we check in a package-lock.json file? When distributing through npm should this file also be distributed?
---
[GitHub] thrift issue #1502: THRIFT-4509: update grunt to 1.0.2
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1502
Okay that sounds good; could you squash and rebase on master to prepare for a merge?
---
[GitHub] thrift issue #1502: THRIFT-4509: update grunt to 1.0.2
Posted by bananer <gi...@git.apache.org>.
Github user bananer commented on the issue:
https://github.com/apache/thrift/pull/1502
The package-lock file keeps dependency versions fixed across all installations. According to [the docs](https://docs.npmjs.com/files/package-lock.json), this does not apply when the package is published on npm, where the file should be excluded.
To update the dependency packages for our builds, one now has to run `npm update` and commit the changed package-lock.json files. This does not impact users of thrift, so I'm not sure if it has to be noted in the Readme or somewhere else.
---