You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "jens mueller (JIRA)" <ji...@apache.org> on 2011/07/03 20:24:21 UTC

[jira] [Created] (CASSANDRA-2852) Cassandra CLI - Import Keyspace Definitions from File - Comments do partitially interpret characters/commands

Cassandra CLI - Import Keyspace Definitions from File - Comments do partitially interpret characters/commands
-------------------------------------------------------------------------------------------------------------

                 Key: CASSANDRA-2852
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2852
             Project: Cassandra
          Issue Type: Bug
          Components: Tools
    Affects Versions: 0.8.1
         Environment: Win Vista 
            Reporter: jens mueller
            Priority: Trivial


Hello, 

using: bin/cassandra-cli -host localhost --file conf/schema-sample.txt

with schema-sample.txt having contents like this:

/* here are a lot of comments,
like this sample create keyspace;
and so on
*/

Will result in an error: 
Line 1 => Syntax Error at Position 323: mismatched charackter '<EOF>' expecting '*'

The Cause is the keyspace; statement.

However:

Writing the word "keyspace;" with quotes, does NOT lead to the error.
so this works: 
/* here are a lot of comments,
like this sample create "keyspace;"
and so on
*/

>From my point of view this is an error. Everyting between the "Start Comment" => /* and "End Comment" => */ Should be treated as a comment and not be interpreted in any way. Thats the definition of a comment, to be not interpreted at all. 

Or this must be documented somewhere very prominently, otherwise this will lead to unnecessary wasting of time searching for this odd behavoiur.

Plattform: Windows Vista

thanks


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2852) Cassandra CLI - Import Keyspace Definitions from File - Comments do partitially interpret characters/commands

Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Yaskevich updated CASSANDRA-2852:
---------------------------------------

    Attachment: CASSANDRA-2852.patch

can be applied on both 0.7 and 0.8 branches.

> Cassandra CLI - Import Keyspace Definitions from File - Comments do partitially interpret characters/commands
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2852
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2852
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.7.0
>         Environment: Win Vista 
>            Reporter: jens mueller
>            Assignee: Pavel Yaskevich
>            Priority: Trivial
>             Fix For: 0.7.7, 0.8.2
>
>         Attachments: CASSANDRA-2852.patch
>
>
> Hello, 
> using: bin/cassandra-cli -host localhost --file conf/schema-sample.txt
> with schema-sample.txt having contents like this:
> /* here are a lot of comments,
> like this sample create keyspace;
> and so on
> */
> Will result in an error: 
> Line 1 => Syntax Error at Position 323: mismatched charackter '<EOF>' expecting '*'
> The Cause is the keyspace; statement => the semicolon ";" causes the error.
> However:
> Writing the word "keyspace;" with quotes, does NOT lead to the error.
> so this works: 
> /* here are a lot of comments,
> like this sample create "keyspace;"
> and so on
> */
> From my point of view this is an error. Everyting between the "Start Comment" => /* and "End Comment" => */ Should be treated as a comment and not be interpreted in any way. Thats the definition of a comment, to be not interpreted at all. 
> Or this must be documented somewhere very prominently, otherwise this will lead to unnecessary wasting of time searching for this odd behavoiur. And it makes "commenting out" statements much more cumbersome.
> Plattform: Windows Vista
> thanks

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2852) Cassandra CLI - Import Keyspace Definitions from File - Comments do partitially interpret characters/commands

Posted by "jens mueller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jens mueller updated CASSANDRA-2852:
------------------------------------

    Description: 
Hello, 

using: bin/cassandra-cli -host localhost --file conf/schema-sample.txt

with schema-sample.txt having contents like this:

/* here are a lot of comments,
like this sample create keyspace;
and so on
*/

Will result in an error: 
Line 1 => Syntax Error at Position 323: mismatched charackter '<EOF>' expecting '*'

The Cause is the keyspace; statement => the semicolon ";" causes the error.

However:

Writing the word "keyspace;" with quotes, does NOT lead to the error.
so this works: 
/* here are a lot of comments,
like this sample create "keyspace;"
and so on
*/

>From my point of view this is an error. Everyting between the "Start Comment" => /* and "End Comment" => */ Should be treated as a comment and not be interpreted in any way. Thats the definition of a comment, to be not interpreted at all. 

Or this must be documented somewhere very prominently, otherwise this will lead to unnecessary wasting of time searching for this odd behavoiur. And it makes "commenting out" statements much more cumbersome.

Plattform: Windows Vista

thanks


  was:
Hello, 

using: bin/cassandra-cli -host localhost --file conf/schema-sample.txt

with schema-sample.txt having contents like this:

/* here are a lot of comments,
like this sample create keyspace;
and so on
*/

Will result in an error: 
Line 1 => Syntax Error at Position 323: mismatched charackter '<EOF>' expecting '*'

The Cause is the keyspace; statement.

However:

Writing the word "keyspace;" with quotes, does NOT lead to the error.
so this works: 
/* here are a lot of comments,
like this sample create "keyspace;"
and so on
*/

>From my point of view this is an error. Everyting between the "Start Comment" => /* and "End Comment" => */ Should be treated as a comment and not be interpreted in any way. Thats the definition of a comment, to be not interpreted at all. 

Or this must be documented somewhere very prominently, otherwise this will lead to unnecessary wasting of time searching for this odd behavoiur.

Plattform: Windows Vista

thanks



> Cassandra CLI - Import Keyspace Definitions from File - Comments do partitially interpret characters/commands
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2852
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2852
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.8.1
>         Environment: Win Vista 
>            Reporter: jens mueller
>            Priority: Trivial
>
> Hello, 
> using: bin/cassandra-cli -host localhost --file conf/schema-sample.txt
> with schema-sample.txt having contents like this:
> /* here are a lot of comments,
> like this sample create keyspace;
> and so on
> */
> Will result in an error: 
> Line 1 => Syntax Error at Position 323: mismatched charackter '<EOF>' expecting '*'
> The Cause is the keyspace; statement => the semicolon ";" causes the error.
> However:
> Writing the word "keyspace;" with quotes, does NOT lead to the error.
> so this works: 
> /* here are a lot of comments,
> like this sample create "keyspace;"
> and so on
> */
> From my point of view this is an error. Everyting between the "Start Comment" => /* and "End Comment" => */ Should be treated as a comment and not be interpreted in any way. Thats the definition of a comment, to be not interpreted at all. 
> Or this must be documented somewhere very prominently, otherwise this will lead to unnecessary wasting of time searching for this odd behavoiur. And it makes "commenting out" statements much more cumbersome.
> Plattform: Windows Vista
> thanks

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-2852) Cassandra CLI - Import Keyspace Definitions from File - Comments do partitially interpret characters/commands

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059513#comment-13059513 ] 

Hudson commented on CASSANDRA-2852:
-----------------------------------

Integrated in Cassandra-0.7 #520 (See [https://builds.apache.org/job/Cassandra-0.7/520/])
    improve cli treatment of multiline comments
patch by pyaskevich; reviewed by jbellis for CASSANDRA-2852

jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1142727
Files : 
* /cassandra/branches/cassandra-0.7/CHANGES.txt
* /cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/cli/CliMain.java


> Cassandra CLI - Import Keyspace Definitions from File - Comments do partitially interpret characters/commands
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2852
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2852
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.7.0
>         Environment: Win Vista 
>            Reporter: jens mueller
>            Assignee: Pavel Yaskevich
>            Priority: Trivial
>             Fix For: 0.7.7, 0.8.2
>
>         Attachments: CASSANDRA-2852.patch
>
>
> Hello, 
> using: bin/cassandra-cli -host localhost --file conf/schema-sample.txt
> with schema-sample.txt having contents like this:
> /* here are a lot of comments,
> like this sample create keyspace;
> and so on
> */
> Will result in an error: 
> Line 1 => Syntax Error at Position 323: mismatched charackter '<EOF>' expecting '*'
> The Cause is the keyspace; statement => the semicolon ";" causes the error.
> However:
> Writing the word "keyspace;" with quotes, does NOT lead to the error.
> so this works: 
> /* here are a lot of comments,
> like this sample create "keyspace;"
> and so on
> */
> From my point of view this is an error. Everyting between the "Start Comment" => /* and "End Comment" => */ Should be treated as a comment and not be interpreted in any way. Thats the definition of a comment, to be not interpreted at all. 
> Or this must be documented somewhere very prominently, otherwise this will lead to unnecessary wasting of time searching for this odd behavoiur. And it makes "commenting out" statements much more cumbersome.
> Plattform: Windows Vista
> thanks

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2852) Cassandra CLI - Import Keyspace Definitions from File - Comments do partitially interpret characters/commands

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2852:
--------------------------------------

    Affects Version/s:     (was: 0.8.1)
                       0.7.0
             Assignee: Pavel Yaskevich

> Cassandra CLI - Import Keyspace Definitions from File - Comments do partitially interpret characters/commands
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2852
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2852
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.7.0
>         Environment: Win Vista 
>            Reporter: jens mueller
>            Assignee: Pavel Yaskevich
>            Priority: Trivial
>
> Hello, 
> using: bin/cassandra-cli -host localhost --file conf/schema-sample.txt
> with schema-sample.txt having contents like this:
> /* here are a lot of comments,
> like this sample create keyspace;
> and so on
> */
> Will result in an error: 
> Line 1 => Syntax Error at Position 323: mismatched charackter '<EOF>' expecting '*'
> The Cause is the keyspace; statement => the semicolon ";" causes the error.
> However:
> Writing the word "keyspace;" with quotes, does NOT lead to the error.
> so this works: 
> /* here are a lot of comments,
> like this sample create "keyspace;"
> and so on
> */
> From my point of view this is an error. Everyting between the "Start Comment" => /* and "End Comment" => */ Should be treated as a comment and not be interpreted in any way. Thats the definition of a comment, to be not interpreted at all. 
> Or this must be documented somewhere very prominently, otherwise this will lead to unnecessary wasting of time searching for this odd behavoiur. And it makes "commenting out" statements much more cumbersome.
> Plattform: Windows Vista
> thanks

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira