You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/06/14 08:05:00 UTC

[jira] [Work logged] (HIVE-25164) Execute Bootstrap REPL load DDL tasks in parallel

     [ https://issues.apache.org/jira/browse/HIVE-25164?focusedWorklogId=610548&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-610548 ]

ASF GitHub Bot logged work on HIVE-25164:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jun/21 08:04
            Start Date: 14/Jun/21 08:04
    Worklog Time Spent: 10m 
      Work Description: aasha commented on a change in pull request #2320:
URL: https://github.com/apache/hive/pull/2320#discussion_r650646490



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
##########
@@ -517,9 +517,9 @@ private static ImportTableDesc getBaseCreateTableDescFromTable(String dbName,
   }
 
   private static Task<?> createTableTask(ImportTableDesc tableDesc, EximUtil.SemanticAnalyzerWrapperContext x,
-                                         String dumpRoot, ReplicationMetricCollector metricCollector) {
+                                         String dumpRoot, ReplicationMetricCollector metricCollector, boolean e) {

Review comment:
       rename to execute parallel

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java
##########
@@ -117,6 +119,6 @@ public String getName() {
    */
   @Override
   public boolean canExecuteInParallel() {
-    return false;
+   return work.isExecuteInParallel();

Review comment:
       nit : rename to canExecuteInParallel?

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
##########
@@ -555,7 +555,7 @@ private static ImportTableDesc getBaseCreateTableDescFromTable(String dbName,
       tableDesc.setReplicationSpec(replicationSpec);
     }
     return tableDesc.getCreateTableTask(x.getInputs(), x.getOutputs(), x.getConf(), isReplication,
-                                        dumpRoot, metricCollector);

Review comment:
       write a test if possible




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 610548)
    Time Spent: 20m  (was: 10m)

> Execute Bootstrap REPL load DDL tasks in parallel
> -------------------------------------------------
>
>                 Key: HIVE-25164
>                 URL: https://issues.apache.org/jira/browse/HIVE-25164
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Pravin Sinha
>            Assignee: Pravin Sinha
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)