You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/04/23 01:40:19 UTC

[GitHub] [helix] dasahcc commented on a change in pull request #961: Change DistributedLock interface APIs

dasahcc commented on a change in pull request #961:
URL: https://github.com/apache/helix/pull/961#discussion_r413446738



##########
File path: helix-lock/src/main/java/org/apache/helix/lock/DistributedLock.java
##########
@@ -24,18 +24,18 @@
  */
 public interface DistributedLock {
   /**
-   * Blocking call to acquire a lock
+   * Blocking call to acquire a lock if it is free at the time of request
    * @return true if the lock was successfully acquired,
    * false if the lock could not be acquired
    */
-  boolean acquireLock();
+  boolean tryLock();
 
   /**
    * Blocking call to release a lock

Review comment:
       unlock 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org