You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by Cong Zhao <zh...@apache.org> on 2023/09/11 03:13:21 UTC

Re: [DISCUSS] PIP-286: Add findNewestPosition method in the TopicCompactionService API

Hi, guys

I noticed that the only globally ordered fields in the metadata are 'publishTime' and 'entryIndex' (offset), so I split the previous method into `findEntryByPublishTime` and `findEntryByEntryIndex`,
this will make method definitions more precise.

The method returns the entry directly instead of RawEntryMetadata to avoid introducing a new interface, it's important to note that the caller needs to release it manually.

I already updated the proposal, please help review it.

Thanks,
Cong Zhao

On 2023/07/25 04:12:09 Cong Zhao wrote:
> Hi Pulsar Community, I am writing to start the discussion on PIP 286  PR
> with PIP contents: https://github.com/apache/pulsar/pull/20867  Thanks,
> Cong Zhao
>

Re: [DISCUSS] PIP-286: Add findNewestPosition method in the TopicCompactionService API

Posted by Zike Yang <zi...@apache.org>.

+1 for me.

Thanks,
Zike Yang

On Mon, Sep 11, 2023 at 11:13 AM Cong Zhao <zh...@apache.org> wrote:
>
> Hi, guys
>
> I noticed that the only globally ordered fields in the metadata are 'publishTime' and 'entryIndex' (offset), so I split the previous method into `findEntryByPublishTime` and `findEntryByEntryIndex`,
> this will make method definitions more precise.
>
> The method returns the entry directly instead of RawEntryMetadata to avoid introducing a new interface, it's important to note that the caller needs to release it manually.
>
> I already updated the proposal, please help review it.
>
> Thanks,
> Cong Zhao
>
> On 2023/07/25 04:12:09 Cong Zhao wrote:
> > Hi Pulsar Community, I am writing to start the discussion on PIP 286  PR
> > with PIP contents: https://github.com/apache/pulsar/pull/20867  Thanks,
> > Cong Zhao
> >