[GitHub] [hbase] infraio commented on a change in pull request #2813: HBASE-23898 Add trace support for simple apis in async client

[GitBox <gi...@apache.org>]

infraio commented on a change in pull request #2813:
URL: https://github.com/apache/hbase/pull/2813#discussion_r549192212



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableImpl.java
##########
@@ -49,85 +51,103 @@
   private final ExecutorService pool;
 
   AsyncTableImpl(AsyncConnectionImpl conn, AsyncTable<AdvancedScanResultConsumer> rawTable,
-      ExecutorService pool) {
+    ExecutorService pool) {
     this.rawTable = rawTable;
     this.pool = pool;
   }
 
+  @WithSpan("AsyncTableImpl.getName")
   @Override
   public TableName getName() {

Review comment:
       Do we need to trace getName or getConfiguration methods? These methods should not cost too much time.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org