[GitHub] [openwhisk] tysonnorris commented on a change in pull request #4915: Add the ability to limit the amount of disk given to the action pod in k8s

[GitBox <gi...@apache.org>]

tysonnorris commented on a change in pull request #4915:
URL: https://github.com/apache/openwhisk/pull/4915#discussion_r435506715



##########
File path: core/invoker/src/main/resources/application.conf
##########
@@ -107,6 +107,14 @@ whisk {
     #  "POD_UID": "metadata.uid"
     #}
 
+    #if missing, the pod will be created without ephermal disk request/limit
+    #if specified, the pod will be created with ephemeral-storage request+limit set
+    #See: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#local-ephemeral-storage
+    #ephemeral-storage {
+    #  limit = 2 g
+    #  request = 500 m

Review comment:
       I know these are defaults, but It seems like a risk to have different limit and request, if exceeding the request but not the limit might cause the pod to terminate or be evicted. I can't tell from the docs if this is the case for ephemeral storage, but docs indicate it is the case e.g. for memory. Since there is currently no recovery from user-action pods that terminate due to kubernetes events despite valid configurations from OW and kubernetes point of view, it might be safer to keep these values the same. If there is no extra risk of termination, of course they can be different, I just don't know. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org