You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2016/08/24 20:48:36 UTC
[GitHub] nifi pull request #933: NiFi-2635 Cluster - Two phase commit
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/933
NiFi-2635 Cluster - Two phase commit
- Using the request from the validation phase in the execution phase.
- Fixing missing REST API documentation.
- Ensuring two phase commit only runs from the cluster coordinator.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-2635
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/933.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #933
----
commit f7d47f300956f034af9f592b1b4f2ce4bcdad85c
Author: Mark Payne <ma...@hotmail.com>
Date: 2016-08-24T19:36:40Z
NIFI-2635:
- Forwarding requests to the coordinator when received by a node.
commit 5915182a116051b5937a4ae927a78d88d3a4fd95
Author: Matt Gilman <ma...@gmail.com>
Date: 2016-08-24T19:39:04Z
NIFI-2635:
- Re-using the original request during the second phase of the two phase commit.
commit fd3f20f020f439e65adf922f8fcb187dabed597e
Author: Matt Gilman <ma...@gmail.com>
Date: 2016-08-24T20:25:54Z
NIFI-2635:
- Fixing contrib check issues.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #933: NiFi-2635 Cluster - Two phase commit
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/933
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #933: NiFi-2635 Cluster - Two phase commit
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/933
I encountered some checkstyle violations building this:
```
[INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @ nifi-web-api ---
[WARNING] src/main/java/org/apache/nifi/web/api/ApplicationResource.java[919:9] (whitespace) FileTabCharacter: Line contains a tab character.
[WARNING] src/main/java/org/apache/nifi/web/api/ControllerResource.java[351] (sizes) LineLength: Line is longer than 200 characters (found 204).
[WARNING] src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java[1315] (sizes) LineLength: Line is longer than 200 characters (found 207).
[WARNING] src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java[2103] (sizes) LineLength: Line is longer than 200 characters (found 204).
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #933: NiFi-2635 Cluster - Two phase commit
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/933
Thanks.. just pushed an updated that should address the contrib check issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #933: NiFi-2635 Cluster - Two phase commit
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/933
+1
Visually verified the code (checked every PUT POST and DELETE that it used the new way method call) and did a contrib check build rebased to master. In a 3 node secure cluster, I believe I tested every possible mutable request and all worked as expected. Also booted up a standealone instance to verify that still worked. Thanks @mcgilman, I will squash and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---