You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "liubao68 (via GitHub)" <gi...@apache.org> on 2023/12/01 07:25:09 UTC
[PR] [SCB-2838]using micrometer to replace spectator [servicecomb-java-chassis]
liubao68 opened a new pull request, #4070:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4070
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SCB-2838]using micrometer to replace spectator [servicecomb-java-chassis]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 merged PR #4070:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SCB-2838]using micrometer to replace spectator [servicecomb-java-chassis]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4070:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4070#issuecomment-1835650053
## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `280 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`d5f5714`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/d5f5714d1afac5675a49996e0ccd884fb617041c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 44.43% compared to head [(`4233d87`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 44.57%.
> :exclamation: Current head 4233d87 differs from pull request most recent head 6732b11. Consider uploading reports for the commit 6732b11 to get more accurate results
| [Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...cecomb/metrics/core/meter/vertx/EndpointMeter.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWV0cmljcy9tZXRyaWNzLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL21ldHJpY3MvY29yZS9tZXRlci92ZXJ0eC9FbmRwb2ludE1ldGVyLmphdmE=) | 0.00% | [53 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...re/meter/ThreadPoolMonitorPublishModelFactory.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWV0cmljcy9tZXRyaWNzLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL21ldHJpY3MvY29yZS9tZXRlci9UaHJlYWRQb29sTW9uaXRvclB1Ymxpc2hNb2RlbEZhY3RvcnkuamF2YQ==) | 0.00% | [30 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...comb/metrics/core/publish/DefaultLogPublisher.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWV0cmljcy9tZXRyaWNzLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL21ldHJpY3MvY29yZS9wdWJsaXNoL0RlZmF1bHRMb2dQdWJsaXNoZXIuamF2YQ==) | 4.54% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...core/meter/invocation/ProducerInvocationMeter.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWV0cmljcy9tZXRyaWNzLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL21ldHJpY3MvY29yZS9tZXRlci9pbnZvY2F0aW9uL1Byb2R1Y2VySW52b2NhdGlvbk1ldGVyLmphdmE=) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...mb/foundation/metrics/publish/MeasurementTree.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9mb3VuZGF0aW9uL21ldHJpY3MvcHVibGlzaC9NZWFzdXJlbWVudFRyZWUuamF2YQ==) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../dashboard/monitor/MetricsMonitorDataProvider.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVhd2VpLWNsb3VkL2Rhc2hib2FyZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvaHVhd2VpY2xvdWQvZGFzaGJvYXJkL21vbml0b3IvTWV0cmljc01vbml0b3JEYXRhUHJvdmlkZXIuamF2YQ==) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ics/core/meter/invocation/EdgeInvocationMeter.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWV0cmljcy9tZXRyaWNzLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL21ldHJpY3MvY29yZS9tZXRlci9pbnZvY2F0aW9uL0VkZ2VJbnZvY2F0aW9uTWV0ZXIuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...cecomb/metrics/prometheus/PrometheusPublisher.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWV0cmljcy9tZXRyaWNzLWludGVncmF0aW9uL21ldHJpY3MtcHJvbWV0aGV1cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbWV0cmljcy9wcm9tZXRoZXVzL1Byb21ldGhldXNQdWJsaXNoZXIuamF2YQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...olution/basic/integration/MetricsEndpointImpl.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c29sdXRpb25zL3NvbHV0aW9uLWJhc2ljL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9zb2x1dGlvbi9iYXNpYy9pbnRlZ3JhdGlvbi9NZXRyaWNzRW5kcG9pbnRJbXBsLmphdmE=) | 9.09% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...mb/foundation/metrics/publish/MeasurementNode.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9mb3VuZGF0aW9uL21ldHJpY3MvcHVibGlzaC9NZWFzdXJlbWVudE5vZGUuamF2YQ==) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [25 more](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4070 +/- ##
============================================
+ Coverage 44.43% 44.57% +0.13%
+ Complexity 5408 5394 -14
============================================
Files 1388 1384 -4
Lines 34214 34165 -49
Branches 3328 3321 -7
============================================
+ Hits 15204 15230 +26
+ Misses 17781 17708 -73
+ Partials 1229 1227 -2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4070?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org