You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/27 16:38:51 UTC

[GitHub] [pulsar-client-reactive] lhotari commented on a diff in pull request #14: Rename methods to use naming convention of [action]One and [action]Many

lhotari commented on code in PR #14:
URL: https://github.com/apache/pulsar-client-reactive/pull/14#discussion_r1007128345


##########
pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageConsumer.java:
##########
@@ -25,9 +25,9 @@
 
 public interface ReactiveMessageConsumer<T> {
 
-	<R> Mono<R> consumeMessage(Function<Mono<Message<T>>, Mono<MessageResult<R>>> messageHandler);
+	<R> Mono<R> consumeOne(Function<Mono<Message<T>>, Publisher<MessageResult<R>>> messageHandler);

Review Comment:
   Yes, the javadoc needs to be addressed too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org