You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/21 15:38:58 UTC
[jira] [Commented] (FLINK-4040) Same env.java.opts is applied for
TM , JM and ZK
[ https://issues.apache.org/jira/browse/FLINK-4040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341999#comment-15341999 ]
ASF GitHub Bot commented on FLINK-4040:
---------------------------------------
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2143
[FLINK-4040] [dist] Allow JobManager/TaskManager-specific JVM args
- Adds two new config keys for the start up scripts:
* `env.java.opts.jobmanager`
* `env.java.opts.taskmanager`
- These are used in addition to the regular `env.java.opts` for the JobManager and TaskManager, respectively.
- Current behaviour is not changed. This does not address the JMX port setting, because that is handled differently.
In the issue, our ZooKeeper utility script is also mentioned, but I think that should not be handled within Flink. That's why I did not add a separate `env.java.opts.zookeeper` key.
@gyfora Can you please review?
---
In general, I've noticed the start up scripts are in a very poor state. They don't follow a coherent style, are not well documented, and not tested automatically. Hence, it's easily possible to break them without noticing it in the scope of our tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink 4040-envopts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2143.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2143
----
commit 6ec0c0e23a915f85be9afe49301c068158e494fb
Author: Ufuk Celebi <uc...@apache.org>
Date: 2016-06-21T15:31:22Z
[FLINK-4040] [dist] Allow JobManager/TaskManager-specific JVM args
- Adds two new config keys for the start up scripts:
* env.java.opts.jobmanager
* env.java.opts.taskmanager
- These are used in addition to the regular env.java.opts for the JobManager
and TaskManager, respectively.
- Current behaviour is not changed. This does not address the JMX port
setting, because that is handled differently.
----
> Same env.java.opts is applied for TM , JM and ZK
> ------------------------------------------------
>
> Key: FLINK-4040
> URL: https://issues.apache.org/jira/browse/FLINK-4040
> Project: Flink
> Issue Type: Bug
> Components: Startup Shell Scripts, YARN Client
> Affects Versions: 1.0.0, 1.1.0
> Reporter: Gyula Fora
> Assignee: Ufuk Celebi
> Priority: Critical
> Fix For: 1.1.0
>
>
> This makes it very hard to fine tune the different processes or to set up profiling on the Task managers.
> We should have dedicated config keys for the 3 processes
> For example if someone wants to setup jmx for the task manager, and the TM and JM runs on the same host they will try to bind to the same jmx port and fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)