You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/11/03 09:21:02 UTC

Review Request 39857: Master/Slave: Add a REASON for TASK_LOST with hard slave drain

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39857/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: MESOS-2077
    https://issues.apache.org/jira/browse/MESOS-2077


Repository: mesos


Description
-------

Update main logic in mesos for both master and slave.


Diffs
-----

  src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
  src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5 
  src/slave/slave.cpp 5f9b52b41eaab0c24965f28e192074340e00bde5 

Diff: https://reviews.apache.org/r/39857/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu


Re: Review Request 39857: Master/Slave: Added a REASON for TASK_LOST with hard slave drain.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39857/
-----------------------------------------------------------

(Updated εδΈ€ζœˆ 4, 2015, 6:31 a.m.)


Review request for mesos and Ben Mahler.


Summary (updated)
-----------------

Master/Slave: Added a REASON for TASK_LOST with hard slave drain.


Bugs: MESOS-2077
    https://issues.apache.org/jira/browse/MESOS-2077


Repository: mesos


Description (updated)
-------

Updated main logic in mesos for both master and slave.


Diffs
-----

  src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
  src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5 
  src/slave/slave.cpp 5f9b52b41eaab0c24965f28e192074340e00bde5 

Diff: https://reviews.apache.org/r/39857/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu


Re: Review Request 39857: Master/Slave: Add a REASON for TASK_LOST with hard slave drain

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39857/#review104886
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38214, 39857]

All tests passed.

- Mesos ReviewBot


On Nov. 3, 2015, 8:21 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39857/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 8:21 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2077
>     https://issues.apache.org/jira/browse/MESOS-2077
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update main logic in mesos for both master and slave.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
>   src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5 
>   src/slave/slave.cpp 5f9b52b41eaab0c24965f28e192074340e00bde5 
> 
> Diff: https://reviews.apache.org/r/39857/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>