You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Kanna Karanam <ka...@microsoft.com> on 2012/07/30 18:00:52 UTC

Review Request: Fix “TestDosToUnix” unit tests on Windows by closing the leaking file handle in DosToUnix.java.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6213/
-----------------------------------------------------------

Review request for hive, Carl Steinbach, Edward  Capriolo, and Ashutosh Chauhan.


Description
-------

Windows can’t delete the files if there are any open file handles on it so it is required to close them properly after completing the validation in DosToUnix utilities.


This addresses bug HIVE-3317.
    https://issues.apache.org/jira/browse/HIVE-3317


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/util/DosToUnix.java 1367127 

Diff: https://reviews.apache.org/r/6213/diff/


Testing
-------

Yes


Thanks,

Kanna Karanam

Re: Review Request: Fix “TestDosToUnix” unit tests on Windows by closing the leaking file handle in DosToUnix.java.

Posted by Kanna Karanam <ka...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6213/
-----------------------------------------------------------

(Updated July 30, 2012, 5:47 p.m.)


Review request for hive, Carl Steinbach, Edward  Capriolo, and Ashutosh Chauhan.


Changes
-------

Attached the diff with updated comment as per JIRA HIVE-3317 comments.


Description
-------

Windows can’t delete the files if there are any open file handles on it so it is required to close them properly after completing the validation in DosToUnix utilities.


This addresses bug HIVE-3317.
    https://issues.apache.org/jira/browse/HIVE-3317


Diffs (updated)
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/util/DosToUnix.java 1367185 

Diff: https://reviews.apache.org/r/6213/diff/


Testing
-------

Yes


Thanks,

Kanna Karanam