You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directmemory.apache.org by Git at Apache <gi...@git.apache.org> on 2012/02/22 22:31:57 UTC

directmemory pull request: [DIRECTMEMORY-43] Cache should allow key objects instead of plain string

GitHub user simonetripodi opened the pull request at
https://github.com/apache/directmemory/pull/2

----
[DIRECTMEMORY-43] Cache should allow key objects instead of plain string

This is my proposal to change the DM signature from <String, Object> to <K, V>.

It contains some signatures modification.

Please review!
----

You can merge this pull request into a Git repository by running
$ git pull https://github.com/simonetripodi/directmemory trunk

Alternatively you can review and apply these changes as the patch at
https://github.com/apache/directmemory/pull/2.patch

Re: directmemory pull request: [DIRECTMEMORY-43] Cache should allow key objects instead of plain string

Posted by Simone Tripodi <si...@apache.org>.
Merci Benoit :)

I'll wait until tonight so someone else will have the chance to take a
look at it, then I'll push it.

Thanks a lot everybody for review!
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Thu, Feb 23, 2012 at 5:00 PM, Benoit Perroud <be...@noisette.ch> wrote:
> Hi All,
>
> I had a chance to go through the pull, it's a big +1.
>
> Thanks Simone !
>
> Benoit.
>
>
>
> 2012/2/23 Tommaso Teofili <to...@gmail.com>:
>> I'm also offline for some days, +1 for pushing it in :)
>> Tommaso
>>
>> 2012/2/23 Olivier Lamy <ol...@apache.org>
>>
>>> Sorry I'm a bit off until saturday to have a look.
>>> So push it :-)
>>>
>>> --
>>> Olivier
>>> Send from a vt100 phone terminal
>>>  Le 23 févr. 2012 13:19, "Simone Tripodi" <si...@apache.org> a
>>> écrit :
>>>
>>> > does anybody have feedbacks to provide? If no objection will be shown,
>>> > I'll assume lazy consensus...
>>> >
>>> > TIA,
>>> > -Simo
>>> >
>>> > http://people.apache.org/~simonetripodi/
>>> > http://simonetripodi.livejournal.com/
>>> > http://twitter.com/simonetripodi
>>> > http://www.99soft.org/
>>> >
>>> >
>>> >
>>> > On Wed, Feb 22, 2012 at 10:31 PM, Git at Apache <gi...@git.apache.org>
>>> > wrote:
>>> > > GitHub user simonetripodi opened the pull request at
>>> > > https://github.com/apache/directmemory/pull/2
>>> > >
>>> > > ----
>>> > > [DIRECTMEMORY-43] Cache should allow key objects instead of plain
>>> string
>>> > >
>>> > > This is my proposal to change the DM signature from <String, Object> to
>>> > <K, V>.
>>> > >
>>> > > It contains some signatures modification.
>>> > >
>>> > > Please review!
>>> > > ----
>>> > >
>>> > > You can merge this pull request into a Git repository by running
>>> > > $ git pull https://github.com/simonetripodi/directmemory trunk
>>> > >
>>> > > Alternatively you can review and apply these changes as the patch at
>>> > > https://github.com/apache/directmemory/pull/2.patch
>>> >
>>>
>
>
>
> --
> sent from my Nokia 3210

Re: directmemory pull request: [DIRECTMEMORY-43] Cache should allow key objects instead of plain string

Posted by Benoit Perroud <be...@noisette.ch>.
Hi All,

I had a chance to go through the pull, it's a big +1.

Thanks Simone !

Benoit.



2012/2/23 Tommaso Teofili <to...@gmail.com>:
> I'm also offline for some days, +1 for pushing it in :)
> Tommaso
>
> 2012/2/23 Olivier Lamy <ol...@apache.org>
>
>> Sorry I'm a bit off until saturday to have a look.
>> So push it :-)
>>
>> --
>> Olivier
>> Send from a vt100 phone terminal
>>  Le 23 févr. 2012 13:19, "Simone Tripodi" <si...@apache.org> a
>> écrit :
>>
>> > does anybody have feedbacks to provide? If no objection will be shown,
>> > I'll assume lazy consensus...
>> >
>> > TIA,
>> > -Simo
>> >
>> > http://people.apache.org/~simonetripodi/
>> > http://simonetripodi.livejournal.com/
>> > http://twitter.com/simonetripodi
>> > http://www.99soft.org/
>> >
>> >
>> >
>> > On Wed, Feb 22, 2012 at 10:31 PM, Git at Apache <gi...@git.apache.org>
>> > wrote:
>> > > GitHub user simonetripodi opened the pull request at
>> > > https://github.com/apache/directmemory/pull/2
>> > >
>> > > ----
>> > > [DIRECTMEMORY-43] Cache should allow key objects instead of plain
>> string
>> > >
>> > > This is my proposal to change the DM signature from <String, Object> to
>> > <K, V>.
>> > >
>> > > It contains some signatures modification.
>> > >
>> > > Please review!
>> > > ----
>> > >
>> > > You can merge this pull request into a Git repository by running
>> > > $ git pull https://github.com/simonetripodi/directmemory trunk
>> > >
>> > > Alternatively you can review and apply these changes as the patch at
>> > > https://github.com/apache/directmemory/pull/2.patch
>> >
>>



-- 
sent from my Nokia 3210

Re: directmemory pull request: [DIRECTMEMORY-43] Cache should allow key objects instead of plain string

Posted by Tommaso Teofili <to...@gmail.com>.
I'm also offline for some days, +1 for pushing it in :)
Tommaso

2012/2/23 Olivier Lamy <ol...@apache.org>

> Sorry I'm a bit off until saturday to have a look.
> So push it :-)
>
> --
> Olivier
> Send from a vt100 phone terminal
>  Le 23 févr. 2012 13:19, "Simone Tripodi" <si...@apache.org> a
> écrit :
>
> > does anybody have feedbacks to provide? If no objection will be shown,
> > I'll assume lazy consensus...
> >
> > TIA,
> > -Simo
> >
> > http://people.apache.org/~simonetripodi/
> > http://simonetripodi.livejournal.com/
> > http://twitter.com/simonetripodi
> > http://www.99soft.org/
> >
> >
> >
> > On Wed, Feb 22, 2012 at 10:31 PM, Git at Apache <gi...@git.apache.org>
> > wrote:
> > > GitHub user simonetripodi opened the pull request at
> > > https://github.com/apache/directmemory/pull/2
> > >
> > > ----
> > > [DIRECTMEMORY-43] Cache should allow key objects instead of plain
> string
> > >
> > > This is my proposal to change the DM signature from <String, Object> to
> > <K, V>.
> > >
> > > It contains some signatures modification.
> > >
> > > Please review!
> > > ----
> > >
> > > You can merge this pull request into a Git repository by running
> > > $ git pull https://github.com/simonetripodi/directmemory trunk
> > >
> > > Alternatively you can review and apply these changes as the patch at
> > > https://github.com/apache/directmemory/pull/2.patch
> >
>

Re: directmemory pull request: [DIRECTMEMORY-43] Cache should allow key objects instead of plain string

Posted by Olivier Lamy <ol...@apache.org>.
Sorry I'm a bit off until saturday to have a look.
So push it :-)

--
Olivier
Send from a vt100 phone terminal
 Le 23 févr. 2012 13:19, "Simone Tripodi" <si...@apache.org> a
écrit :

> does anybody have feedbacks to provide? If no objection will be shown,
> I'll assume lazy consensus...
>
> TIA,
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
>
> On Wed, Feb 22, 2012 at 10:31 PM, Git at Apache <gi...@git.apache.org>
> wrote:
> > GitHub user simonetripodi opened the pull request at
> > https://github.com/apache/directmemory/pull/2
> >
> > ----
> > [DIRECTMEMORY-43] Cache should allow key objects instead of plain string
> >
> > This is my proposal to change the DM signature from <String, Object> to
> <K, V>.
> >
> > It contains some signatures modification.
> >
> > Please review!
> > ----
> >
> > You can merge this pull request into a Git repository by running
> > $ git pull https://github.com/simonetripodi/directmemory trunk
> >
> > Alternatively you can review and apply these changes as the patch at
> > https://github.com/apache/directmemory/pull/2.patch
>

Re: directmemory pull request: [DIRECTMEMORY-43] Cache should allow key objects instead of plain string

Posted by Simone Tripodi <si...@apache.org>.
does anybody have feedbacks to provide? If no objection will be shown,
I'll assume lazy consensus...

TIA,
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Wed, Feb 22, 2012 at 10:31 PM, Git at Apache <gi...@git.apache.org> wrote:
> GitHub user simonetripodi opened the pull request at
> https://github.com/apache/directmemory/pull/2
>
> ----
> [DIRECTMEMORY-43] Cache should allow key objects instead of plain string
>
> This is my proposal to change the DM signature from <String, Object> to <K, V>.
>
> It contains some signatures modification.
>
> Please review!
> ----
>
> You can merge this pull request into a Git repository by running
> $ git pull https://github.com/simonetripodi/directmemory trunk
>
> Alternatively you can review and apply these changes as the patch at
> https://github.com/apache/directmemory/pull/2.patch