You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "bvolpato (via GitHub)" <gi...@apache.org> on 2023/07/20 12:26:15 UTC

[GitHub] [beam] bvolpato commented on pull request #27534: [Java][Schemas] Improve performance of GetterBasedSchemaProvider#fromRowFunction

bvolpato commented on PR #27534:
URL: https://github.com/apache/beam/pull/27534#issuecomment-1643833955

   Wow! That's awesome, great improvements. Nice work.
   
   I don't have any red flags, just slightly concerned if we have good test coverage around this change. It seems that we don't have unit tests for any of `FromRowUsingCreator` / `GetterBasedSchemaProvider`, but we rely on `GetterBasedSchemaProvider`'s subclasses to be tested (`AutoValueSchemaTest`, `AvroSchemaTest`, `ThriftSchemaTest`, `JavaFieldSchemaTest`, `JavaBeanSchemaTest`, `ProtoMessageSchemaTest`). 
   
   I think it should be fine, but I don't know if we cover all scenarios (I'll try to look at some of those tests).
   
   @chamikaramj Can you please take a look too?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org