You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/04/24 11:44:59 UTC

[GitHub] [rocketmq] RongtongJin commented on a change in pull request #1958: [ISSUE 1950] fix DefaultMQProducer didn't shutdown completely

RongtongJin commented on a change in pull request #1958:
URL: https://github.com/apache/rocketmq/pull/1958#discussion_r414511810



##########
File path: client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
##########
@@ -853,6 +853,7 @@ public void shutdown() {
                     this.scheduledExecutorService.shutdown();
                     this.mQClientAPIImpl.shutdown();
                     this.rebalanceService.shutdown();
+                    this.defaultMQProducer.shutdown();

Review comment:
       `this.defaultMQProducer.shutdown();` and `this.defaultMQProducer.getDefaultMQProducerImpl().shutdown(false);`  conflict?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org