You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Yasser Zamani <ya...@apache.org> on 2021/04/30 13:40:42 UTC
lazy consensus state for PR#483,4,5
Hi,
I will merge these PRs (483 to 485) in 72 hours based on ASF lazy
consensus definition [1] unless someone objects.
Regards.
[1] https://community.apache.org/committers/lazyConsensus.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: lazy consensus state for PR#483,496
Posted by "info@flyingfischer.ch" <in...@flyingfischer.ch>.
I did take a look at
https://github.com/apache/struts/pull/483
https://github.com/apache/struts/pull/496
This seems to me too big of a change for the current 2.5 branch. It
should be reconsidered or reevaluated eventually for an upcoming 2.6
branch. It also seems sensible to me to have a user-configurable
override as discussed in the discussion of pull request 483, to avoid
any eventually possible and unforeseen breaking behavior.
-1 to the merge these PRs
Markus
Am 24.07.21 um 14:36 schrieb Lukasz Lenart:
> pt., 23 lip 2021 o 17:56 Yasser Zamani <ya...@apache.org> napisał(a):
>> Hi,
>>
>> Thanks , comments on 483 addressed and corresponding 496 created by
>> cherry pick and manual merge.
>>
>> I will merge these PRs (483 and 496) in 72 hours based on ASF lazy
>> consensus definition [1] unless someone objects.
> I'm against introducing such huge changes in a minor version like
> 2.5.27, I'm ok having breaking changes in 2.6
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: lazy consensus state for PR#483,496
Posted by Lukasz Lenart <lu...@apache.org>.
pt., 23 lip 2021 o 17:56 Yasser Zamani <ya...@apache.org> napisał(a):
>
> Hi,
>
> Thanks , comments on 483 addressed and corresponding 496 created by
> cherry pick and manual merge.
>
> I will merge these PRs (483 and 496) in 72 hours based on ASF lazy
> consensus definition [1] unless someone objects.
I'm against introducing such huge changes in a minor version like
2.5.27, I'm ok having breaking changes in 2.6
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: lazy consensus state for PR#483,496
Posted by Yasser Zamani <ya...@apache.org>.
Hi,
Thanks , comments on 483 addressed and corresponding 496 created by
cherry pick and manual merge.
I will merge these PRs (483 and 496) in 72 hours based on ASF lazy
consensus definition [1] unless someone objects.
Regards.
[1] https://community.apache.org/committers/lazyConsensus.html
On 4/30/2021 6:10 PM, Yasser Zamani wrote:
> Hi,
>
> I will merge these PRs (483 to 485) in 72 hours based on ASF lazy
> consensus definition [1] unless someone objects.
>
> Regards.
>
> [1] https://community.apache.org/committers/lazyConsensus.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org