[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #18804: [fix][broker] Fix namespace deletion if __change_events topic has not been created yet

[GitBox <gi...@apache.org>]

nicoloboschi commented on code in PR #18804:
URL: https://github.com/apache/pulsar/pull/18804#discussion_r1044173204


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java:
##########
@@ -1648,6 +1648,11 @@ public void testDeleteNamespaceWithTopicPolicies() throws Exception {
 
         // create namespace2
         String namespace = tenant + "/test-ns2";
+        admin.namespaces().createNamespace(namespace, Set.of("test"));
+        admin.topics().createNonPartitionedTopic(namespace + "/tobedeleted");
+        // verify namespace can be deleted even without topic policy events

Review Comment:
   it's the scope of this pull 😁 
   When deleting namespace with force=true, you first delete the topics in it. For each topics deleted, a new event is generated. However if the __change_events doesn't exist yet, it's auto-created. But the creation fails since the namespace is being deleted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org