You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "Sean Mackrory (JIRA)" <ji...@apache.org> on 2014/01/24 19:19:38 UTC

[jira] [Comment Edited] (BIGTOP-1193) Update Spark packaging for various conventions

    [ https://issues.apache.org/jira/browse/BIGTOP-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881240#comment-13881240 ] 

Sean Mackrory edited comment on BIGTOP-1193 at 1/24/14 6:18 PM:
----------------------------------------------------------------

Sounds good to me - patch updated. While I was at it, the common/spark/run file does not appear to be used, so I yanked that too. Packages still build fine and I can't find that file in previously built packages. Is that cool with you, [~cos]?


was (Author: mackrorysd):
Sounds good to me. While I was at it, the common/spark/run file does not appear to be used, so I yanked that too. Packages still build fine and I can't find that file in previously built packages. Is that cool with you, [~cos]?

> Update Spark packaging for various conventions
> ----------------------------------------------
>
>                 Key: BIGTOP-1193
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1193
>             Project: Bigtop
>          Issue Type: Bug
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>         Attachments: 0001-BIGTOP-1193.-Update-Spark-packaging-for-various-conv.patch, 0001-BIGTOP-1193.-Update-Spark-packaging-for-various-conv.patch
>
>
> This is a bit of a mixed bag of things I noticed:
> * We're using the old style of checking multiple locations for bigtop-utils. If we depend on bigtop-utils 0.7 we can safely assume where it is.
> * We're invoking install_spark.sh with `sh` instead of `bash` in one place - someone's going to get a cryptic syntax error one day :)
> * We're invoking do-component-build in deb/.../rules with an unnecessary environment variable (accidentally introduced in BIGTOP-1150 - it's a downstream modification specific to a Certain Distribution of Hadoop based on Bigtop).



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)