You are viewing a plain text version of this content. The canonical link for it is here.

Posted to c-dev@xerces.apache.org by xe...@xml.apache.org on 2004/09/21 21:12:37 UTC

[jira] Closed: (XERCESC-1150) XMLStringPool is not useful as a base class

Message:

   The following issue has been closed.

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/XERCESC-1150

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: XERCESC-1150
    Summary: XMLStringPool is not useful as a base class
       Type: Bug

     Status: Closed
 Resolution: FIXED

    Project: Xerces-C++
 Components: 
             Utilities
   Versions:
             Nightly build (please specify the date)

   Assignee: 
   Reporter: David Bertoni

    Created: Mon, 16 Feb 2004 4:47 PM
    Updated: Tue, 21 Sep 2004 12:11 PM
Environment: Operating System: All
Platform: All

Description:
XMLStringPool is used in the interface of multiple abstract base classes in 
Xerces-C.  However, it is a concrete class, which is a very bad design.

Even more, it is not amenable to derivation, since none of its data members 
are protected (except, strangely, its fCurId member).  Anyone wishing to 
implement their own string pool must provide their own implementation, but 
still have the baggage of the base class implementation.

My suggestion would be to make XMLStringPool and abstract base class, call the 
current class XMLStringPoolImpl, and make all of its data members protected.  
That would give implementors the best of both possible worlds.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org