You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pe...@apache.org on 2012/05/02 12:07:21 UTC
git commit: WICKET-4527 Recorder#getSelectedChoices() can be very
slow under certain circumstances
Updated Branches:
refs/heads/wicket-1.5.x ed638d451 -> 8527aa0af
WICKET-4527 Recorder#getSelectedChoices() can be very slow under certain circumstances
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/8527aa0a
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/8527aa0a
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/8527aa0a
Branch: refs/heads/wicket-1.5.x
Commit: 8527aa0af66375955c87cd5d0b909f6097c2af11
Parents: ed638d4
Author: Peter Ertl <pe...@apache.org>
Authored: Wed May 2 12:05:10 2012 +0200
Committer: Peter Ertl <pe...@apache.org>
Committed: Wed May 2 12:05:10 2012 +0200
----------------------------------------------------------------------
.../html/form/palette/component/Recorder.java | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/8527aa0a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java
index 03d33df..dd6acf8 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java
@@ -152,10 +152,11 @@ public class Recorder<T> extends HiddenField<Object>
return Collections.EMPTY_LIST.iterator();
}
+ Collection<? extends T> choices = getPalette().getChoices();
List<T> selected = new ArrayList<T>(ids.length);
for (String id : ids)
{
- for (T choice : getPalette().getChoices())
+ for (T choice : choices)
{
if (renderer.getIdValue(choice, 0).equals(id))
{