You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tiles.apache.org by ap...@apache.org on 2008/02/17 15:16:14 UTC
svn commit: r628488 - in /tiles/framework/trunk:
tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/RenderTagSupport.java
tiles-test/src/test/selenium/ConfiguredDefinitionExceptionTest.html
Author: apetrelli
Date: Sun Feb 17 06:16:06 2008
New Revision: 628488
URL: http://svn.apache.org/viewvc?rev=628488&view=rev
Log:
TILES-238
Now RenderTagSupport does not implement TryCatchFinally anymore: exceptions pass through.
Fixed corresponding Selenium test.
Modified:
tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/RenderTagSupport.java
tiles/framework/trunk/tiles-test/src/test/selenium/ConfiguredDefinitionExceptionTest.html
Modified: tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/RenderTagSupport.java
URL: http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/RenderTagSupport.java?rev=628488&r1=628487&r2=628488&view=diff
==============================================================================
--- tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/RenderTagSupport.java (original)
+++ tiles/framework/trunk/tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/RenderTagSupport.java Sun Feb 17 06:16:06 2008
@@ -20,14 +20,11 @@
*/
package org.apache.tiles.jsp.taglib;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.tiles.Attribute;
import org.apache.tiles.TilesException;
import org.apache.tiles.Attribute.AttributeType;
import javax.servlet.jsp.JspException;
-import javax.servlet.jsp.tagext.TryCatchFinally;
import java.io.IOException;
/**
@@ -47,12 +44,7 @@
* @version $Rev$ $Date$
*/
public abstract class RenderTagSupport extends ContainerTagSupport
- implements TryCatchFinally, PutAttributeTagParent {
-
- /**
- * The logging object.
- */
- private static final Log LOG = LogFactory.getLog(RenderTagSupport.class);
+ implements PutAttributeTagParent {
/**
* The view preparer to use before the rendering.
@@ -145,15 +137,6 @@
public int doStartTag() throws JspException {
super.doStartTag();
return isAccessAllowed() ? EVAL_BODY_BUFFERED : SKIP_BODY;
- }
-
- /** {@inheritDoc} */
- public void doCatch(Throwable throwable) throws Throwable {
- LOG.error("Error during rendering", throwable);
- }
-
- /** {@inheritDoc} */
- public void doFinally() {
}
/**
Modified: tiles/framework/trunk/tiles-test/src/test/selenium/ConfiguredDefinitionExceptionTest.html
URL: http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-test/src/test/selenium/ConfiguredDefinitionExceptionTest.html?rev=628488&r1=628487&r2=628488&view=diff
==============================================================================
--- tiles/framework/trunk/tiles-test/src/test/selenium/ConfiguredDefinitionExceptionTest.html (original)
+++ tiles/framework/trunk/tiles-test/src/test/selenium/ConfiguredDefinitionExceptionTest.html Sun Feb 17 06:16:06 2008
@@ -41,12 +41,7 @@
<td></td>
</tr>
<tr>
- <td>assertTextPresent</td>
- <td>This is the title.</td>
- <td></td>
-</tr>
-<tr>
- <td>assertTextPresent</td>
+ <td>assertTextNotPresent</td>
<td>This is a body</td>
<td></td>
</tr>