[jira] [Updated] (WICKET-3850) Unnecessary static call to Application.get() in PropertiesFactory though it's already available in a field

["Peter Ertl (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-3850:
-------------------------------

    Summary: Unnecessary static call to Application.get() in PropertiesFactory though it's already available in a field  (was: Use of Application inside PropertiesFactory is inconsistent)

> Unnecessary static call to Application.get() in PropertiesFactory though it's already available in a field
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3850
>                 URL: https://issues.apache.org/jira/browse/WICKET-3850
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.4.17, 1.5-RC5.1
>            Reporter: Frédéric Donckels
>            Assignee: Peter Ertl
>            Priority: Minor
>             Fix For: 1.5-RC6
>
>
> PropertiesFactory is taking an Application argument in its constructor and then in the load(..) method it does: Application.get().xxxx.
> This seems inconsistent to me.
> In addition, when looking at the uses of the application instance, it could just have an IResourceSettings parameter, rather than a full blown Application instance.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira