You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (Created) (JIRA)" <ji...@apache.org> on 2012/03/17 18:53:37 UTC

[jira] [Created] (CASSANDRA-4061) Decommission should take a token

Decommission should take a token
--------------------------------

                 Key: CASSANDRA-4061
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4061
             Project: Cassandra
          Issue Type: Bug
            Reporter: Brandon Williams
            Assignee: Brandon Williams
             Fix For: 1.2


Like removetoken, decom should take a token parameter.  This is a bit easier said than done because it changes gossip, but I've seen enough people burned by this (as I have myself.)  In the short term though *decommission still accepts a token parameter* which I thought we had fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CASSANDRA-4061) Decommission should take a token

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271503#comment-13271503 ] 

Brandon Williams edited comment on CASSANDRA-4061 at 5/9/12 3:57 PM:
---------------------------------------------------------------------

To the dismay of my OCD, after looking at the options I think calling decommission on the host you want to decommission is the cleanest option we have.

However, as stated, nodetool should definitely not allow miscellaneous args to get passed, allow users to think it's doing something other than what it is.  Patch to fix this and clarify the help message, against 1.0 in the unlikely case we ever have reason to roll a 1.0.11.
                
      was (Author: brandon.williams):
    To the dismay of my OCD, after looking at the options I think calling decommission on the host you want to decommission is the cleanest option we have.

However, as stated, nodetool should definitely not allow miscellaneous args to get passed, allow users to think it's doing something other than what it is.  Patch to fix this and clarify the help message, against 1.0 in the unlikely case we ever have reason to roll a 1.1.11.
                  
> Decommission should take a token
> --------------------------------
>
>                 Key: CASSANDRA-4061
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4061
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 1.0.11
>
>         Attachments: 4061.txt
>
>
> Like removetoken, decom should take a token parameter.  This is a bit easier said than done because it changes gossip, but I've seen enough people burned by this (as I have myself.)  In the short term though *decommission still accepts a token parameter* which I thought we had fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-4061) Decommission should take a token

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-4061:
----------------------------------------

    Fix Version/s:     (was: 1.2)
                   1.0.11
    
> Decommission should take a token
> --------------------------------
>
>                 Key: CASSANDRA-4061
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4061
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 1.0.11
>
>         Attachments: 4061.txt
>
>
> Like removetoken, decom should take a token parameter.  This is a bit easier said than done because it changes gossip, but I've seen enough people burned by this (as I have myself.)  In the short term though *decommission still accepts a token parameter* which I thought we had fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-4061) Decommission should take a token

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-4061:
----------------------------------------

    Attachment: 4061.txt

To the dismay of my OCD, after looking at the options I think calling decommission on the host you want to decommission is the cleanest option we have.

However, as stated, nodetool should definitely not allow miscellaneous args to get passed, allow users to think it's doing something other than what it is.  Patch to fix this and clarify the help message, against 1.0 in the unlikely case we ever have reason to roll a 1.1.11.
                
> Decommission should take a token
> --------------------------------
>
>                 Key: CASSANDRA-4061
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4061
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 1.0.11
>
>         Attachments: 4061.txt
>
>
> Like removetoken, decom should take a token parameter.  This is a bit easier said than done because it changes gossip, but I've seen enough people burned by this (as I have myself.)  In the short term though *decommission still accepts a token parameter* which I thought we had fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CASSANDRA-4061) Decommission should take a token

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams resolved CASSANDRA-4061.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.1

Committed.
                
> Decommission should take a token
> --------------------------------
>
>                 Key: CASSANDRA-4061
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4061
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 1.0.11, 1.1.1
>
>         Attachments: 4061.txt
>
>
> Like removetoken, decom should take a token parameter.  This is a bit easier said than done because it changes gossip, but I've seen enough people burned by this (as I have myself.)  In the short term though *decommission still accepts a token parameter* which I thought we had fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4061) Decommission should take a token

Posted by "MaHaiyang (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233373#comment-13233373 ] 

MaHaiyang commented on CASSANDRA-4061:
--------------------------------------

I think using "./nodetool -h host -p port decommission " is  more simple than using "./nodetool -h host -p port decommision <the node's token>" . If "./nodetool -h host -p port decommision <the node's token>"  could be available ,it  can't be better.
                
> Decommission should take a token
> --------------------------------
>
>                 Key: CASSANDRA-4061
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4061
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 1.2
>
>
> Like removetoken, decom should take a token parameter.  This is a bit easier said than done because it changes gossip, but I've seen enough people burned by this (as I have myself.)  In the short term though *decommission still accepts a token parameter* which I thought we had fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-4061) Decommission should take a token

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-4061:
----------------------------------------

    Reviewer: vijay2win@yahoo.com
    
> Decommission should take a token
> --------------------------------
>
>                 Key: CASSANDRA-4061
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4061
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 1.0.11
>
>         Attachments: 4061.txt
>
>
> Like removetoken, decom should take a token parameter.  This is a bit easier said than done because it changes gossip, but I've seen enough people burned by this (as I have myself.)  In the short term though *decommission still accepts a token parameter* which I thought we had fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4061) Decommission should take a token

Posted by "Vijay (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271554#comment-13271554 ] 

Vijay commented on CASSANDRA-4061:
----------------------------------

+1
                
> Decommission should take a token
> --------------------------------
>
>                 Key: CASSANDRA-4061
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4061
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 1.0.11
>
>         Attachments: 4061.txt
>
>
> Like removetoken, decom should take a token parameter.  This is a bit easier said than done because it changes gossip, but I've seen enough people burned by this (as I have myself.)  In the short term though *decommission still accepts a token parameter* which I thought we had fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira