You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "YxYL6125 (via GitHub)" <gi...@apache.org> on 2023/12/02 07:22:31 UTC
[PR] [type:fix][ISSUE #5332] Fix restart plugin. [shenyu]
YxYL6125 opened a new pull request, #5337:
URL: https://github.com/apache/shenyu/pull/5337
<!-- Describe your PR here; e.g. Fixes #issueNo -->
Fixes https://github.com/apache/shenyu/issues/5332 & https://github.com/apache/shenyu/issues/5292
changes:
- add remove cache logic when closing plugin in class AbstractLogPluginDataHandler.
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:fix][ISSUE #5332] Fix restart plugin. [shenyu]
Posted by "YxYL6125 (via GitHub)" <gi...@apache.org>.
YxYL6125 closed pull request #5337: [type:fix][ISSUE #5332] Fix restart plugin.
URL: https://github.com/apache/shenyu/pull/5337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:fix][ISSUE #5332] Fix restart plugin. [shenyu]
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on PR #5337:
URL: https://github.com/apache/shenyu/pull/5337#issuecomment-1837136547
not right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:fix][ISSUE #5332] Fix restart plugin. [shenyu]
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on PR #5337:
URL: https://github.com/apache/shenyu/pull/5337#issuecomment-1837137705
#5332 because ext plugin has been removed from plugins cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:fix][ISSUE #5332] Fix restart plugin. [shenyu]
Posted by "YxYL6125 (via GitHub)" <gi...@apache.org>.
YxYL6125 commented on PR #5337:
URL: https://github.com/apache/shenyu/pull/5337#issuecomment-1837145975
> #5332 because ext plugin has been removed from plugins cache
It is, my negligence :sweat_drops:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:fix][ISSUE #5332] Fix restart plugin. [shenyu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5337:
URL: https://github.com/apache/shenyu/pull/5337#issuecomment-1837075785
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5337?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `3 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`ec26dc0`)](https://app.codecov.io/gh/apache/shenyu/commit/ec26dc0b968d8142006b34cbcc0672b30d6d6481?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.86% compared to head [(`307b469`)](https://app.codecov.io/gh/apache/shenyu/pull/5337?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.83%.
| [Files](https://app.codecov.io/gh/apache/shenyu/pull/5337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/shenyu/common/utils/Singleton.java](https://app.codecov.io/gh/apache/shenyu/pull/5337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9TaW5nbGV0b24uamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/shenyu/pull/5337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...g/common/handler/AbstractLogPluginDataHandler.java](https://app.codecov.io/gh/apache/shenyu/pull/5337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9sb2dnaW5nL2NvbW1vbi9oYW5kbGVyL0Fic3RyYWN0TG9nUGx1Z2luRGF0YUhhbmRsZXIuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/shenyu/pull/5337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #5337 +/- ##
============================================
- Coverage 61.86% 61.83% -0.03%
+ Complexity 8691 8690 -1
============================================
Files 1255 1255
Lines 38348 38351 +3
Branches 3673 3673
============================================
- Hits 23725 23716 -9
- Misses 12508 12520 +12
Partials 2115 2115
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/shenyu/pull/5337?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org