You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "Fabian Lange (Created) (JIRA)" <ji...@apache.org> on 2012/01/01 16:51:30 UTC
[jira] [Created] (TIKA-837) Make inner classes static for
performance reasons
Make inner classes static for performance reasons
-------------------------------------------------
Key: TIKA-837
URL: https://issues.apache.org/jira/browse/TIKA-837
Project: Tika
Issue Type: Sub-task
Components: general
Reporter: Fabian Lange
Attachments: static_classes_patch.diff
Sonar lists these as major violations, because static classes perform generally better. This is because the JVM needs only to create one class definition.
There are a few others, but those could even benefit from a larger refactoring than just making them static inner classes
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TIKA-837) Make inner classes static for
performance reasons
Posted by "Nick Burch (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Burch resolved TIKA-837.
-----------------------------
Resolution: Fixed
Fix Version/s: 1.1
> Make inner classes static for performance reasons
> -------------------------------------------------
>
> Key: TIKA-837
> URL: https://issues.apache.org/jira/browse/TIKA-837
> Project: Tika
> Issue Type: Sub-task
> Components: general
> Reporter: Fabian Lange
> Fix For: 1.1
>
> Attachments: static_classes_patch.diff
>
>
> Sonar lists these as major violations, because static classes perform generally better. This is because the JVM needs only to create one class definition.
> There are a few others, but those could even benefit from a larger refactoring than just making them static inner classes
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TIKA-837) Make inner classes static for
performance reasons
Posted by "Fabian Lange (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fabian Lange updated TIKA-837:
------------------------------
Attachment: static_classes_patch.diff
> Make inner classes static for performance reasons
> -------------------------------------------------
>
> Key: TIKA-837
> URL: https://issues.apache.org/jira/browse/TIKA-837
> Project: Tika
> Issue Type: Sub-task
> Components: general
> Reporter: Fabian Lange
> Attachments: static_classes_patch.diff
>
>
> Sonar lists these as major violations, because static classes perform generally better. This is because the JVM needs only to create one class definition.
> There are a few others, but those could even benefit from a larger refactoring than just making them static inner classes
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TIKA-837) Make inner classes static for
performance reasons
Posted by "Nick Burch (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178638#comment-13178638 ]
Nick Burch commented on TIKA-837:
---------------------------------
Thanks, patch applied in r1226657.
> Make inner classes static for performance reasons
> -------------------------------------------------
>
> Key: TIKA-837
> URL: https://issues.apache.org/jira/browse/TIKA-837
> Project: Tika
> Issue Type: Sub-task
> Components: general
> Reporter: Fabian Lange
> Fix For: 1.1
>
> Attachments: static_classes_patch.diff
>
>
> Sonar lists these as major violations, because static classes perform generally better. This is because the JVM needs only to create one class definition.
> There are a few others, but those could even benefit from a larger refactoring than just making them static inner classes
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira