You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/10/03 17:53:35 UTC
[jira] [Commented] (SHINDIG-1630) Need to override the toString
method in org.apache.shindig.gadgets.servlet.GadgetsHandlerApi.Location
[ https://issues.apache.org/jira/browse/SHINDIG-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119375#comment-13119375 ]
jiraposter@reviews.apache.org commented on SHINDIG-1630:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2144/
-----------------------------------------------------------
(Updated 2011-10-03 15:53:29.823897)
Review request for shindig and Henry Saputra.
Changes
-------
Updated the bug link to relative instead of absolute
Summary
-------
Had to override the default toString() method in org.apache.shindig.gadgets.servlet.GadgetsHandlerApi.Location to return the underlying value in Enum, instead of the Enum name, to mimic the class used in the spec package.
This addresses bug SHINDIG-1630.
https://issues.apache.org/jira/browse/SHINDIG-1630
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1174912
Diff: https://reviews.apache.org/r/2144/diff
Testing
-------
Manual testing.
Thanks,
Igor
> Need to override the toString method in org.apache.shindig.gadgets.servlet.GadgetsHandlerApi.Location
> -----------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1630
> URL: https://issues.apache.org/jira/browse/SHINDIG-1630
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.3, 3.0.0
> Reporter: Igor Belakovskiy
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: OAuthLocation.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> need the method to return the underlying string value, instead of the Enum name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira