[jira] [Created] (STORM-796) The "error" command isn't supported on ShellSpout

["Andrew Montalenti (JIRA)" <ji...@apache.org>]

Andrew Montalenti created STORM-796:
---------------------------------------

             Summary: The "error" command isn't supported on ShellSpout
                 Key: STORM-796
                 URL: https://issues.apache.org/jira/browse/STORM-796
             Project: Apache Storm
          Issue Type: Bug
    Affects Versions: 0.9.4
            Reporter: Andrew Montalenti
            Assignee: Andrew Montalenti
             Fix For: 0.10.0


The `ShellBolt` can handle the "error" command, as shown in this file in Storm source code:

https://github.com/apache/storm/blob/2dd7a9426e5634211f14cf5c4e10e021d3420c3c/storm-core/src/jvm/backtype/storm/task/ShellBolt.java#L330

But, `ShellSpout` does not actually have a handler for "error".

https://github.com/apache/storm/blob/2dd7a9426e5634211f14cf5c4e10e021d3420c3c/storm-core/src/jvm/backtype/storm/spout/ShellSpout.java#L153-L175

The symptoms a multi-lang user will see here is that if their Spout throws an error and their multi-lang implementation sends an "error" command up to the ShellSpout, the ShellSpout will respond saying that it doesn't recognize the "error" command, and thus it will crash (while swallowing the exception thrown by the underlying multi-lang component).

I am about to open a PR on Github that fixes this.

Originally reported on the streamparse project in this Github issue:

https://github.com/Parsely/streamparse/issues/121



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)