You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/12/03 14:43:52 UTC

[GitHub] mdeuser opened a new pull request #4153: optionally prohibit test cases using --auth to override the namespace target

mdeuser opened a new pull request #4153: optionally prohibit test cases using --auth to override the namespace target
URL: https://github.com/apache/incubator-openwhisk/pull/4153
 
 
   ## Description
   Existing CLI test cases implicitly target the namespace via the `--auth` flag.  In some test scenarios, it's desirable to run the tests using the configured namespace without having the `--auth` override.  This change enables the existing CLI test cases to be run against the configured namespace.  The existing tests are left as-is.  To take advantage of this feature
   - create a wrapper trait ("NewRunCliCmd") that extends an existing `RunCliCmd` trait.  Inside this new trait, override the `prohibitAuthOverride` property value with a value of `true`
   - create a wrapper wsk cli class ("NewWsk") that extends the `Wsk` class.  This new class will also extend your "NewRunCliCmd" class
   - create a wrapper test class that extends an existing test class.  Inside this new class, override the `wsk` property with an instance of your "NewWsk" class.
   
   ## Related issue and scope
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [x] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.  *Existing tests should run as before*
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services