Re: svn commit: r1721121 - in /httpd/httpd/trunk/modules/http2: h2_h2.c h2_io.c h2_io.h h2_mplx.h h2_push.c h2_request.c h2_request.h h2_session.c h2_session.h h2_stream.c h2_stream.h h2_task.c h2_task.h h2_task_output.h h2_worker.h h2_workers.h

[Christophe JAILLET <ch...@wanadoo.fr>]

Le 21/12/2015 18:41, Mike Rumph a écrit :
> Comment below:
>
> Thanks,
>
> Mike
>
> On 12/21/2015 2:54 AM, icing@apache.org wrote:
>> Author: icing
>> Date: Mon Dec 21 10:54:38 2015
>> New Revision: 1721121
>>
>> URL: http://svn.apache.org/viewvc?rev=1721121&view=rev
>> Log:
>> byte savings by using bit fields, new env vars HTTP2 and H2PUSH, set 
>> to on when enabled on request
>>
>> ============================================================================== 
>>
>> --- httpd/httpd/trunk/modules/http2/h2_io.h (original)
>> +++ httpd/httpd/trunk/modules/http2/h2_io.h Mon Dec 21 10:54:38 2015
>> @@ -38,29 +38,30 @@ typedef struct h2_io h2_io;
>>   struct h2_io {
> * * *
>> +
>> +    int orphaned       : 1;      /* h2_stream is gone for this io */
>> +    int task_done      : 1;      /* h2_task has finished for this io */
>> +    int request_body   : 1;      /* iff request has body */
>> +    int eos_in         : 1;      /* input eos has been seen */
>> +    int eos_in_written : 1;      /* input eos has been forwarded */
>> +    int eos_out        : 1;      /* output eos has been seen */
>> +
>>
> There have been past dev discussions on problems related to using 
> signed bitfields.
> Using unsigned int avoids these problems.
>
Fixed in r1721137 and r1721138 (and r1721139 which is not related to 
mod_http2)

CJ