[jira] Commented: (NUTCH-4) Serious bug: OutOfMemoryError: Java heap space

["Piotr Kosiorowski (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/NUTCH-4?page=comments#action_62272 ]
     
Piotr Kosiorowski commented on NUTCH-4:
---------------------------------------

Some time ago I sent a patch for this with JUnit test on the list - but it was using old package naming.  I had plans to resubmit it last week but due to amount of other work I have posponed it. Anyway there is one difference between your and mine solution:
I have added one additional method:
void nonTermOrEOF() :
{}
{
  nonTerm() | <EOF>
}
and changed:
/** Parse anything but a term or an operator (plur or minus or quote). */
void nonOpOrTerm() :
{}
{
  (LOOKAHEAD(2) (<WHITE> | nonOpInfix() | ((<PLUS>|<MINUS>) nonTerm())))*
}

into

/** Parse anything but a term or an operator (plur or minus or quote). */
void nonOpOrTerm() :
{}
{
  (LOOKAHEAD(2) (<WHITE> | nonOpInfix() | ((<PLUS>|<MINUS>) nonTermOrEOF())))*
}


My solution allows to parse:
"test +" query as "test"
in your case such query throws parse exception.

I can send the patch again if you wish so we can merge our versions. I will have a look at Junit tests too, to see if they can/should be merged.


> Serious bug: OutOfMemoryError: Java heap space
> ----------------------------------------------
>
>          Key: NUTCH-4
>          URL: http://issues.apache.org/jira/browse/NUTCH-4
>      Project: Nutch
>         Type: Bug
>     Reporter: Stefan Grroschupf
>     Assignee: Sami Siren
>  Attachments: query_parser_unbalanced_fix.tar.gz
>
> posted by: msashnikov
> http://sourceforge.net/tracker/index.php?func=detail&aid=1110947&group_id=59548&atid=491356
> Serious bug: OutOfMemoryError: Java heap space
> Nutch 0.6 throws the following exception when the 
> search phrase includes just a single quote. Something 
> like "java or ja"va.
> Here is the exception:
> javax.servlet.ServletException: Java heap space
> org.apache.jasper.runtime.PageContextImpl.doH
> andlePageException(PageContextImpl.java:845)
> org.apache.jasper.runtime.PageContextImpl.han
> dlePageException(PageContextImpl.java:778)
> org.apache.jsp.search_jsp._jspService
> (org.apache.jsp.search_jsp:685)
> org.apache.jasper.runtime.HttpJspBase.service
> (HttpJspBase.java:99)
> javax.servlet.http.HttpServlet.service
> (HttpServlet.java:802)
> org.apache.jasper.servlet.JspServletWrapper.se
> rvice(JspServletWrapper.java:325)
> org.apache.jasper.servlet.JspServlet.serviceJsp
> File(JspServlet.java:295)
> org.apache.jasper.servlet.JspServlet.service
> (JspServlet.java:245)
> javax.servlet.http.HttpServlet.service
> (HttpServlet.java:802)
> root cause 
> java.lang.OutOfMemoryError: Java heap space

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

Re: [jira] Commented: (NUTCH-4) Serious bug: OutOfMemoryError: Java heap space

[Sami Siren <s....@sonera.inet.fi>]

ok, sorry about that - I must have missed your patch. please attach it 
to jira.

--
  Sami Siren


Piotr Kosiorowski (JIRA) wrote:
>      [ http://issues.apache.org/jira/browse/NUTCH-4?page=comments#action_62272 ]
>      
> Piotr Kosiorowski commented on NUTCH-4:
> ---------------------------------------
> 
> Some time ago I sent a patch for this with JUnit test on the list - but it was using old package naming.  I had plans to resubmit it last week but due to amount of other work I have posponed it. Anyway there is one difference between your and mine solution:
> I have added one additional method:
> void nonTermOrEOF() :
> {}
> {
>   nonTerm() | <EOF>
> }
> and changed:
> /** Parse anything but a term or an operator (plur or minus or quote). */
> void nonOpOrTerm() :
> {}
> {
>   (LOOKAHEAD(2) (<WHITE> | nonOpInfix() | ((<PLUS>|<MINUS>) nonTerm())))*
> }
> 
> into
> 
> /** Parse anything but a term or an operator (plur or minus or quote). */
> void nonOpOrTerm() :
> {}
> {
>   (LOOKAHEAD(2) (<WHITE> | nonOpInfix() | ((<PLUS>|<MINUS>) nonTermOrEOF())))*
> }
> 
> 
> My solution allows to parse:
> "test +" query as "test"
> in your case such query throws parse exception.
> 
> I can send the patch again if you wish so we can merge our versions. I will have a look at Junit tests too, to see if they can/should be merged.
> 
>