You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/09 00:53:08 UTC

[GitHub] [superset] yousoph opened a new issue #13018: [SQL Lab] Restyle Existing Display Limit Warning

yousoph opened a new issue #13018:
URL: https://github.com/apache/superset/issues/13018


   ## Screenshot
   ![Clipboard_2021-25-01_at_11 13 23_PM](https://user-images.githubusercontent.com/10627051/107300020-860cf200-6a2d-11eb-81fd-2a8f2dbdd09b.png)
   
   ## Description
   How to Repro: 
   * Set DISPLAY_MAX_ROW to a low number 
   * Run a query with the LIMIT dropdown set to a number higher than DISPLAY_MAX_ROW 
   The orange LIMIT indicator that appears wasn't styled with the new toolbar and appears twice. 
   
   Remove the current indicator and add the ! indicator and message based on mocks. 
   Admin view: https://www.figma.com/file/5db2MpaKNnC1c7MK9ysdeV/SQL-Limit-Indicator?node-id=90%3A210 
   Non-admin view: https://www.figma.com/file/5db2MpaKNnC1c7MK9ysdeV/SQL-Limit-Indicator?node-id=90%3A352


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] yousoph closed issue #13018: [SQL Lab] Restyle Existing Display Limit Warning

Posted by GitBox <gi...@apache.org>.
yousoph closed issue #13018:
URL: https://github.com/apache/superset/issues/13018


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org