You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/07/09 21:54:51 UTC
Re: Review Request 70957: Added registry operation for marking an
agent as drained.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70957/#review216455
-----------------------------------------------------------
Fix it, then Ship it!
src/master/registry_operations.cpp
Lines 467-468 (patched)
<https://reviews.apache.org/r/70957/#comment303694>
Nit: do we usually place the logical operator at the end of the preceding line? Ditto below.
src/master/registry_operations.cpp
Lines 469 (patched)
<https://reviews.apache.org/r/70957/#comment303693>
s/in/is/
- Greg Mann
On June 26, 2019, 8:45 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70957/
> -----------------------------------------------------------
>
> (Updated June 26, 2019, 8:45 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-9814
> https://issues.apache.org/jira/browse/MESOS-9814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds an operation purely for transitioning an agent from the
> DRAINING state to the DRAINED state. The master is expected to
> validate that the targetted agent is DRAINING, otherwise, the
> write will fail (which results in the master aborting).
>
>
> Diffs
> -----
>
> src/master/registry_operations.hpp 5a3010d46c4eddb0d660eb7368ec836903477a9b
> src/master/registry_operations.cpp c417c4d6c4272eeab15f5313ca5160d4a0aa4da4
> src/tests/registrar_tests.cpp 81979d78f1348791e28f1afea4ca2999de6362b8
>
>
> Diff: https://reviews.apache.org/r/70957/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>