[GitHub] [incubator-dolphinscheduler] gabrywu commented on a change in pull request #4015: [Fix][api] Fix build parameter error of sqlserver when create.

[GitBox <gi...@apache.org>]

gabrywu commented on a change in pull request #4015:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4015#discussion_r517847579



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
##########
@@ -499,7 +499,13 @@ public String buildParameter(DbType type, String host,
 
         String address = buildAddress(type, host, port, connectType);
         Map<String, Object> parameterMap = new LinkedHashMap<String, Object>(6);
-        String jdbcUrl = address + "/" + database;
+        String jdbcUrl;
+        if (DbType.SQLSERVER == type) {
+            jdbcUrl = address + ";databaseName=" + database;
+        } else {
+            jdbcUrl = address + "/" + database;
+        }
+
         if (Constants.ORACLE.equals(type.name())) {

Review comment:
       Do you mind removing the following constants? I think using '==' is better, after all, the 'type' variable is Enum
   
       public static final String MYSQL = "MYSQL";
       public static final String POSTGRESQL = "POSTGRESQL";
       public static final String HIVE = "HIVE";
       public static final String SPARK = "SPARK";
       public static final String CLICKHOUSE = "CLICKHOUSE";
       public static final String ORACLE = "ORACLE";
       public static final String SQLSERVER = "SQLSERVER";
       public static final String DB2 = "DB2";
       public static final String PRESTO = "PRESTO";




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org