You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by se...@apache.org on 2010/05/15 02:42:15 UTC

svn commit: r944537 - in /jakarta/jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java xdocs/changes.xml

Author: sebb
Date: Sat May 15 00:42:15 2010
New Revision: 944537

URL: http://svn.apache.org/viewvc?rev=944537&view=rev
Log:
Bug 49294 - Images not downloaded from redirected-to pages

Modified:
    jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
    jakarta/jmeter/trunk/xdocs/changes.xml

Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=944537&r1=944536&r2=944537&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java Sat May 15 00:42:15 2010
@@ -1306,8 +1306,6 @@ public abstract class HTTPSamplerBase ex
             if (frameDepth > MAX_FRAME_DEPTH) {
                 res.addSubResult(errorResult(new Exception("Maximum frame/iframe nesting depth exceeded."), res));
             } else {
-                // If we followed redirects, we already have a container:
-                if(!areFollowingRedirect) {
                 HTTPSampleResult container = (HTTPSampleResult) (areFollowingRedirect ? res.getParent() : res);
 
                 // Only download page resources if we were not redirected.
@@ -1316,7 +1314,6 @@ public abstract class HTTPSamplerBase ex
                 if(!wasRedirected) {
                     res = downloadPageResources(res, container, frameDepth);
                 }
-                }
             }
         }
         return res;

Modified: jakarta/jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/changes.xml?rev=944537&r1=944536&r2=944537&view=diff
==============================================================================
--- jakarta/jmeter/trunk/xdocs/changes.xml (original)
+++ jakarta/jmeter/trunk/xdocs/changes.xml Sat May 15 00:42:15 2010
@@ -91,6 +91,7 @@ This does not affect existing test plans
 <li>Bug 48570 - AjpSampler doesn't support query parameters (GET/POST)</li>
 <li>Bug 46901 - HTTP Sampler does not process var/func refs correctly in first file parameter</li>
 <li>Bug 43678 - Handle META tag http-equiv charset?</li>
+<li>Bug 49294 - Images not downloaded from redirected-to pages</li>
 </ul>
 
 <h3>Other Samplers</h3>



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org