You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2012/05/25 17:08:23 UTC

[jira] [Commented] (BOOKKEEPER-260) Define constant for -1 (invalid entry id)

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283517#comment-13283517 ] 

Sijie Guo commented on BOOKKEEPER-260:
--------------------------------------

the patch looks good to me. +1
                
> Define constant for -1 (invalid entry id)
> -----------------------------------------
>
>                 Key: BOOKKEEPER-260
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-260
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-260.diff
>
>
> We should define a constant for -1, as we use it all over the place to signify an invalid entry id. We should call it INVALID_ENTRY_ID or NO_ENTRY or something to the same affect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira