You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "lowka (via GitHub)" <gi...@apache.org> on 2025/04/07 09:23:01 UTC

[PR] IGNITE-24824 Sql. Add SQL logic tests for TIMESTAMP WITH LOCAL TIME ZONE type [ignite-3]

lowka opened a new pull request, #5578:
URL: https://github.com/apache/ignite-3/pull/5578

   
   
   ---
   
   Thank you for submitting the pull request.
   
   To streamline the review process of the patch and ensure better code quality
   we ask both an author and a reviewer to verify the following:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT was made, WHY and HOW.  
   \- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the components it is added to.
   - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
   - [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-24824 Sql. Add SQL logic tests for TIMESTAMP WITH LOCAL TIME ZONE type [ignite-3]

Posted by "xtern (via GitHub)" <gi...@apache.org>.
xtern commented on code in PR #5578:
URL: https://github.com/apache/ignite-3/pull/5578#discussion_r2032578262


##########
modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz.test:
##########
@@ -0,0 +1,265 @@
+# name: test/sql/types/timestamp/test_timestamp.test
+# description: Test TIMESTAMP WITH LOCAL TIME ZONE type
+# group: [timestamp]
+
+statement ok
+PRAGMA enable_verification
+
+statement ok
+PRAGMA time_zone=Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'::VARCHAR
+----
+2017-07-23 13:10:11 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'
+----
+2017-07-23T11:10:11Z
+
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    ';
+
+# other trailing, preceding, or middle gunk is not accepted
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    AA';
+
+query I
+SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01');
+----
+1992
+
+query I
+SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01'::DATE);
+----
+1992
+
+query T
+SELECT (TIMESTAMP '1992-01-01 01:01:01')::DATE;
+----
+1992-01-01
+
+query T
+SELECT (TIMESTAMP '1992-01-01 01:01:01')::TIME;
+----
+01:01:01
+
+query T
+SELECT (DATE '1992-01-01')::TIMESTAMP WITH LOCAL TIME ZONE::VARCHAR;
+----
+1992-01-01 00:00:00 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5'
+----
+2007-12-31T23:00:01.500Z
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5'::VARCHAR
+----
+2008-01-01 00:00:01.5 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999'
+----
+2007-12-31T23:00:01.999Z
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999'::VARCHAR
+----
+2008-01-01 00:00:01.999 Europe/Paris
+
+# timestamp with large date
+# actual error message is  000/-12-31 23:00:0
+# statement error: Date literal 'TIMESTAMP WITH LOCAL TIME ZONE '0000-01-01 00:00:01.5'' out of range
+statement error
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '100000-01-01 00:00:01.5'::VARCHAR
+
+query T
+SELECT '2008-01-01 00:00:01.999'::TIMESTAMP WITH LOCAL TIME ZONE::VARCHAR
+----
+2008-01-01 00:00:01.999 Europe/Paris
+
+# Value must be rounded up.

Review Comment:
   Please add TODO 
   ```
   TODO https://issues.apache.org/jira/browse/IGNITE-25045 Result must have specified precision
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-24824 Sql. Add SQL logic tests for TIMESTAMP WITH LOCAL TIME ZONE type [ignite-3]

Posted by "lowka (via GitHub)" <gi...@apache.org>.
lowka commented on code in PR #5578:
URL: https://github.com/apache/ignite-3/pull/5578#discussion_r2032952028


##########
modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz.test:
##########
@@ -0,0 +1,265 @@
+# name: test/sql/types/timestamp/test_timestamp.test

Review Comment:
   Done.



##########
modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz.test:
##########
@@ -0,0 +1,265 @@
+# name: test/sql/types/timestamp/test_timestamp.test
+# description: Test TIMESTAMP WITH LOCAL TIME ZONE type
+# group: [timestamp]
+
+statement ok
+PRAGMA enable_verification
+
+statement ok
+PRAGMA time_zone=Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'::VARCHAR
+----
+2017-07-23 13:10:11 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'
+----
+2017-07-23T11:10:11Z
+
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    ';
+
+# other trailing, preceding, or middle gunk is not accepted
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    AA';
+
+query I
+SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01');

Review Comment:
   Thanks. Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-24824 Sql. Add SQL logic tests for TIMESTAMP WITH LOCAL TIME ZONE type [ignite-3]

Posted by "xtern (via GitHub)" <gi...@apache.org>.
xtern merged PR #5578:
URL: https://github.com/apache/ignite-3/pull/5578


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-24824 Sql. Add SQL logic tests for TIMESTAMP WITH LOCAL TIME ZONE type [ignite-3]

Posted by "lowka (via GitHub)" <gi...@apache.org>.
lowka commented on code in PR #5578:
URL: https://github.com/apache/ignite-3/pull/5578#discussion_r2032949151


##########
modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz_timestamp.test:
##########
@@ -0,0 +1,62 @@
+# name: test/sql/types/timestamp/test_timestamp.test

Review Comment:
   Thanks. Fixed.



##########
modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz.test:
##########
@@ -0,0 +1,265 @@
+# name: test/sql/types/timestamp/test_timestamp.test
+# description: Test TIMESTAMP WITH LOCAL TIME ZONE type
+# group: [timestamp]
+
+statement ok
+PRAGMA enable_verification
+
+statement ok
+PRAGMA time_zone=Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'::VARCHAR
+----
+2017-07-23 13:10:11 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'
+----
+2017-07-23T11:10:11Z
+
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    ';
+
+# other trailing, preceding, or middle gunk is not accepted
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    AA';
+
+query I
+SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01');
+----
+1992
+
+query I
+SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01'::DATE);
+----
+1992
+
+query T
+SELECT (TIMESTAMP '1992-01-01 01:01:01')::DATE;
+----
+1992-01-01
+
+query T
+SELECT (TIMESTAMP '1992-01-01 01:01:01')::TIME;
+----
+01:01:01
+
+query T
+SELECT (DATE '1992-01-01')::TIMESTAMP WITH LOCAL TIME ZONE::VARCHAR;
+----
+1992-01-01 00:00:00 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5'
+----
+2007-12-31T23:00:01.500Z
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5'::VARCHAR
+----
+2008-01-01 00:00:01.5 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999'
+----
+2007-12-31T23:00:01.999Z
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999'::VARCHAR
+----
+2008-01-01 00:00:01.999 Europe/Paris
+
+# timestamp with large date
+# actual error message is  000/-12-31 23:00:0
+# statement error: Date literal 'TIMESTAMP WITH LOCAL TIME ZONE '0000-01-01 00:00:01.5'' out of range
+statement error
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '100000-01-01 00:00:01.5'::VARCHAR
+
+query T
+SELECT '2008-01-01 00:00:01.999'::TIMESTAMP WITH LOCAL TIME ZONE::VARCHAR
+----
+2008-01-01 00:00:01.999 Europe/Paris
+
+# Value must be rounded up.

Review Comment:
   Fixed.



##########
modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz.test:
##########
@@ -0,0 +1,265 @@
+# name: test/sql/types/timestamp/test_timestamp.test
+# description: Test TIMESTAMP WITH LOCAL TIME ZONE type
+# group: [timestamp]
+
+statement ok
+PRAGMA enable_verification
+
+statement ok
+PRAGMA time_zone=Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'::VARCHAR
+----
+2017-07-23 13:10:11 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'
+----
+2017-07-23T11:10:11Z
+
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    ';
+
+# other trailing, preceding, or middle gunk is not accepted
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    AA';
+
+query I
+SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01');
+----
+1992
+
+query I
+SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01'::DATE);
+----
+1992
+
+query T
+SELECT (TIMESTAMP '1992-01-01 01:01:01')::DATE;
+----
+1992-01-01
+
+query T
+SELECT (TIMESTAMP '1992-01-01 01:01:01')::TIME;
+----
+01:01:01
+
+query T
+SELECT (DATE '1992-01-01')::TIMESTAMP WITH LOCAL TIME ZONE::VARCHAR;
+----
+1992-01-01 00:00:00 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5'
+----
+2007-12-31T23:00:01.500Z
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5'::VARCHAR
+----
+2008-01-01 00:00:01.5 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999'
+----
+2007-12-31T23:00:01.999Z
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999'::VARCHAR
+----
+2008-01-01 00:00:01.999 Europe/Paris
+
+# timestamp with large date
+# actual error message is  000/-12-31 23:00:0
+# statement error: Date literal 'TIMESTAMP WITH LOCAL TIME ZONE '0000-01-01 00:00:01.5'' out of range

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-24824 Sql. Add SQL logic tests for TIMESTAMP WITH LOCAL TIME ZONE type [ignite-3]

Posted by "xtern (via GitHub)" <gi...@apache.org>.
xtern commented on code in PR #5578:
URL: https://github.com/apache/ignite-3/pull/5578#discussion_r2032558783


##########
modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz.test:
##########
@@ -0,0 +1,265 @@
+# name: test/sql/types/timestamp/test_timestamp.test
+# description: Test TIMESTAMP WITH LOCAL TIME ZONE type
+# group: [timestamp]
+
+statement ok
+PRAGMA enable_verification
+
+statement ok
+PRAGMA time_zone=Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'::VARCHAR
+----
+2017-07-23 13:10:11 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'
+----
+2017-07-23T11:10:11Z
+
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    ';
+
+# other trailing, preceding, or middle gunk is not accepted
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    AA';
+
+query I
+SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01');

Review Comment:
   should it be `TIMESTAMP WITH LOCAL TIME ZONE`?
   (here and below)



##########
modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz_timestamp.test:
##########
@@ -0,0 +1,62 @@
+# name: test/sql/types/timestamp/test_timestamp.test

Review Comment:
   ```suggestion
   # name: test/sql/types/timestamp/test_timestamp_ltz_timestamp.test
   ```



##########
modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz.test:
##########
@@ -0,0 +1,265 @@
+# name: test/sql/types/timestamp/test_timestamp.test

Review Comment:
   ```suggestion
   # name: test/sql/types/timestamp/test_timestamp_ltz.test
   ```
   
   :warning: Can you please also add `test_incorrect_timestamp_ltz.test` with copy-pasted test cases from `test_incorrect_timestamp.test`?



##########
modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz.test:
##########
@@ -0,0 +1,265 @@
+# name: test/sql/types/timestamp/test_timestamp.test
+# description: Test TIMESTAMP WITH LOCAL TIME ZONE type
+# group: [timestamp]
+
+statement ok
+PRAGMA enable_verification
+
+statement ok
+PRAGMA time_zone=Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'::VARCHAR
+----
+2017-07-23 13:10:11 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'
+----
+2017-07-23T11:10:11Z
+
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    ';
+
+# other trailing, preceding, or middle gunk is not accepted
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    AA';
+
+query I
+SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01');
+----
+1992
+
+query I
+SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01'::DATE);
+----
+1992
+
+query T
+SELECT (TIMESTAMP '1992-01-01 01:01:01')::DATE;
+----
+1992-01-01
+
+query T
+SELECT (TIMESTAMP '1992-01-01 01:01:01')::TIME;
+----
+01:01:01
+
+query T
+SELECT (DATE '1992-01-01')::TIMESTAMP WITH LOCAL TIME ZONE::VARCHAR;
+----
+1992-01-01 00:00:00 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5'
+----
+2007-12-31T23:00:01.500Z
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5'::VARCHAR
+----
+2008-01-01 00:00:01.5 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999'
+----
+2007-12-31T23:00:01.999Z
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999'::VARCHAR
+----
+2008-01-01 00:00:01.999 Europe/Paris
+
+# timestamp with large date
+# actual error message is  000/-12-31 23:00:0
+# statement error: Date literal 'TIMESTAMP WITH LOCAL TIME ZONE '0000-01-01 00:00:01.5'' out of range

Review Comment:
   Please add TODO https://issues.apache.org/jira/browse/IGNITE-24984



##########
modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz.test:
##########
@@ -0,0 +1,265 @@
+# name: test/sql/types/timestamp/test_timestamp.test
+# description: Test TIMESTAMP WITH LOCAL TIME ZONE type
+# group: [timestamp]
+
+statement ok
+PRAGMA enable_verification
+
+statement ok
+PRAGMA time_zone=Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'::VARCHAR
+----
+2017-07-23 13:10:11 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'
+----
+2017-07-23T11:10:11Z
+
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    ';
+
+# other trailing, preceding, or middle gunk is not accepted
+statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '    2017-07-23     13:10:11    AA';
+
+query I
+SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01');
+----
+1992
+
+query I
+SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01'::DATE);
+----
+1992
+
+query T
+SELECT (TIMESTAMP '1992-01-01 01:01:01')::DATE;
+----
+1992-01-01
+
+query T
+SELECT (TIMESTAMP '1992-01-01 01:01:01')::TIME;
+----
+01:01:01
+
+query T
+SELECT (DATE '1992-01-01')::TIMESTAMP WITH LOCAL TIME ZONE::VARCHAR;
+----
+1992-01-01 00:00:00 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5'
+----
+2007-12-31T23:00:01.500Z
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5'::VARCHAR
+----
+2008-01-01 00:00:01.5 Europe/Paris
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999'
+----
+2007-12-31T23:00:01.999Z
+
+query T
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999'::VARCHAR
+----
+2008-01-01 00:00:01.999 Europe/Paris
+
+# timestamp with large date
+# actual error message is  000/-12-31 23:00:0
+# statement error: Date literal 'TIMESTAMP WITH LOCAL TIME ZONE '0000-01-01 00:00:01.5'' out of range
+statement error
+SELECT TIMESTAMP WITH LOCAL TIME ZONE '100000-01-01 00:00:01.5'::VARCHAR
+
+query T
+SELECT '2008-01-01 00:00:01.999'::TIMESTAMP WITH LOCAL TIME ZONE::VARCHAR
+----
+2008-01-01 00:00:01.999 Europe/Paris
+
+# Value must be rounded up.

Review Comment:
   Please add TODO 
   TODO https://issues.apache.org/jira/browse/IGNITE-25045 Result must have specified precision



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org