You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/11/08 03:52:34 UTC
[GitHub] [incubator-kyuubi] deadwind4 opened a new pull request, #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
deadwind4 opened a new pull request, #3779:
URL: https://github.com/apache/incubator-kyuubi/pull/3779
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [X] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#discussion_r1114086452
##########
.github/workflows/master.yml:
##########
@@ -182,6 +182,14 @@ jobs:
java-version: ${{ matrix.java }}
cache: 'maven'
check-latest: false
+ - name: Setup Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: '3.8'
+ - name: Install a PyFlink dependency
+ run: |
+ python -m pip install --upgrade pip
Review Comment:
if `pip` is available, we don't need to install/upgrade it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] a49a commented on a diff in pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "a49a (via GitHub)" <gi...@apache.org>.
a49a commented on code in PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#discussion_r1114174559
##########
.github/workflows/master.yml:
##########
@@ -182,6 +182,14 @@ jobs:
java-version: ${{ matrix.java }}
cache: 'maven'
check-latest: false
+ - name: Setup Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: '3.8'
Review Comment:
I have added version matrix in he PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#discussion_r1118594614
##########
.github/workflows/master.yml:
##########
@@ -188,8 +188,8 @@ jobs:
python-version: '3.8'
- name: Install a PyFlink dependency
run: |
- python -m pip install --upgrade pip
- pip install apache-flink==${{ matrix.flink }}.0
+ FLINK_VERSION=`mvn help:evaluate -Dexpression=flink.version -Pflink-${{ matrix.flink }} -q -DforceStdout | grep -E '[0-9]+\.[0-9]+\.[0-9]+' -o`
Review Comment:
`mvn` => `build/mvn`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #3773][FLINK] Support Flink Python UDF [kyuubi]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#issuecomment-2811314805
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!
Thank you for using Kyuubi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] a49a commented on a diff in pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "a49a (via GitHub)" <gi...@apache.org>.
a49a commented on code in PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#discussion_r1122682800
##########
.github/workflows/master.yml:
##########
@@ -182,6 +182,14 @@ jobs:
java-version: ${{ matrix.java }}
cache: 'maven'
check-latest: false
+ - name: Setup Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: '3.8'
+ - name: Install a PyFlink dependency
+ run: |
+ python -m pip install --upgrade pip
+ pip install apache-flink==${{ matrix.flink }}.0
Review Comment:
I found `matrix.flink-archive` may be a '', so I derive a Flink version from `pom.xml` like `mvn help:evaluate -Dexpression=flink.version -Pflink-${{ matrix.flink }} -q -DforceStdout`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#discussion_r1112799003
##########
pom.xml:
##########
@@ -137,6 +137,7 @@
<flexmark.version>0.62.2</flexmark.version>
<flink.version>1.16.1</flink.version>
<flink.module.scala.suffix></flink.module.scala.suffix>
+ <flink.python.module.scala.suffix></flink.python.module.scala.suffix>
Review Comment:
can we avoid introducing this property by leveraging the maven transitive dependency mechanism?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #3773][FLINK] Support Flink Python UDF [kyuubi]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
URL: https://github.com/apache/kyuubi/pull/3779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] a49a commented on a diff in pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "a49a (via GitHub)" <gi...@apache.org>.
a49a commented on code in PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#discussion_r1114097138
##########
.github/workflows/master.yml:
##########
@@ -182,6 +182,14 @@ jobs:
java-version: ${{ matrix.java }}
cache: 'maven'
check-latest: false
+ - name: Setup Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: '3.8'
Review Comment:
Flink 1.16 only started supporting Python 3.9, so we can't align the Python version to Spark.
I chose the highest Python version in Flink 1.14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] a49a commented on a diff in pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "a49a (via GitHub)" <gi...@apache.org>.
a49a commented on code in PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#discussion_r1113752641
##########
pom.xml:
##########
@@ -137,6 +137,7 @@
<flexmark.version>0.62.2</flexmark.version>
<flink.version>1.16.1</flink.version>
<flink.module.scala.suffix></flink.module.scala.suffix>
+ <flink.python.module.scala.suffix></flink.python.module.scala.suffix>
Review Comment:
The `flink-python` module is individual. There are no flink modules that depend on it. After we drop the 1.14 and 1.15 version, we can remove this property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] a49a commented on a diff in pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "a49a (via GitHub)" <gi...@apache.org>.
a49a commented on code in PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#discussion_r1114097138
##########
.github/workflows/master.yml:
##########
@@ -182,6 +182,14 @@ jobs:
java-version: ${{ matrix.java }}
cache: 'maven'
check-latest: false
+ - name: Setup Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: '3.8'
Review Comment:
Flink 1.16 only started supporting Python 3.9, so we can't align the Python version to Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#discussion_r1114103188
##########
.github/workflows/master.yml:
##########
@@ -182,6 +182,14 @@ jobs:
java-version: ${{ matrix.java }}
cache: 'maven'
check-latest: false
+ - name: Setup Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: '3.8'
Review Comment:
can you supply a flink/python version matrix in the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#issuecomment-1438137128
# [Codecov](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3779](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8706a4e) into [master](https://codecov.io/gh/apache/kyuubi/commit/7eac6ea0f9437386d1ba2b58902269187e6a52c5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7eac6ea) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3779 +/- ##
============================================
+ Coverage 53.69% 53.73% +0.04%
Complexity 13 13
============================================
Files 564 564
Lines 30893 30900 +7
Branches 4164 4164
============================================
+ Hits 16588 16605 +17
+ Misses 12748 12739 -9
+ Partials 1557 1556 -1
```
| [Impacted Files](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/engine/flink/FlinkProcessBuilder.scala](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvZmxpbmsvRmxpbmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `73.52% <100.00%> (+2.10%)` | :arrow_up: |
| [...g/apache/kyuubi/operation/BatchJobSubmission.scala](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vQmF0Y2hKb2JTdWJtaXNzaW9uLnNjYWxh) | `75.27% <0.00%> (-2.20%)` | :arrow_down: |
| [.../engine/spark/session/SparkSQLSessionManager.scala](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zZXNzaW9uL1NwYXJrU1FMU2Vzc2lvbk1hbmFnZXIuc2NhbGE=) | `78.75% <0.00%> (-1.00%)` | :arrow_down: |
| [...ttp/authentication/AuthenticationAuditLogger.scala](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvaHR0cC9hdXRoZW50aWNhdGlvbi9BdXRoZW50aWNhdGlvbkF1ZGl0TG9nZ2VyLnNjYWxh) | `100.00% <0.00%> (ø)` | |
| [...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbWV0YWRhdGEvamRiYy9KREJDTWV0YWRhdGFTdG9yZS5zY2FsYQ==) | `88.42% <0.00%> (+0.64%)` | :arrow_up: |
| [...pache/kyuubi/server/metadata/MetadataManager.scala](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbWV0YWRhdGEvTWV0YWRhdGFNYW5hZ2VyLnNjYWxh) | `84.27% <0.00%> (+1.25%)` | :arrow_up: |
| [...ache/kyuubi/server/mysql/MySQLGenericPackets.scala](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxHZW5lcmljUGFja2V0cy5zY2FsYQ==) | `78.72% <0.00%> (+2.12%)` | :arrow_up: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `82.66% <0.00%> (+2.66%)` | :arrow_up: |
| [...ache/kyuubi/server/mysql/MySQLCommandHandler.scala](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxDb21tYW5kSGFuZGxlci5zY2FsYQ==) | `81.81% <0.00%> (+4.04%)` | :arrow_up: |
| [.../kyuubi/server/mysql/constant/MySQLErrorCode.scala](https://codecov.io/gh/apache/kyuubi/pull/3779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvY29uc3RhbnQvTXlTUUxFcnJvckNvZGUuc2NhbGE=) | `20.00% <0.00%> (+6.15%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#issuecomment-1438149564
What's the Flink Python version support matrix? And are you suppose to let Kyuubi fully matched?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#discussion_r1114088293
##########
.github/workflows/master.yml:
##########
@@ -182,6 +182,14 @@ jobs:
java-version: ${{ matrix.java }}
cache: 'maven'
check-latest: false
+ - name: Setup Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: '3.8'
+ - name: Install a PyFlink dependency
+ run: |
+ python -m pip install --upgrade pip
+ pip install apache-flink==${{ matrix.flink }}.0
Review Comment:
We can get the exact flink version by
```
IT_FLINK=`echo "${{ matrix.flink-archive }}" | grep -E 'flink\-([0-9]+\.[0-9]+.[0-9]+)\-bin' -o | grep -E '[0-9]+\.[0-9]+' -o`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #3773][FLINK] Support Flink Python UDF [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#issuecomment-1782271246
Kyuubi 1.9 goes to support Flink 1.16 to 1.19, would you like to rebase this PR and switch to python 3.9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] a49a commented on pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "a49a (via GitHub)" <gi...@apache.org>.
a49a commented on PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#issuecomment-1438192663
> What's the Flink Python version support matrix? Do you suppose to let Kyuubi fully match?
The Python version of Flink is unrelated to Kyuubi. Users can refer to [Flink Python version support](https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/dev/python/datastream_tutorial/#how-to-follow-along) and set the [`python.executable`](https://nightlies.apache.org/flink/flink-docs-master/docs/dev/python/python_config/#python-executable) option to specify the Python interpreter version.
So Kyuubi Flink SQL engine can ignore the Flink Python version problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] a49a commented on pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "a49a (via GitHub)" <gi...@apache.org>.
a49a commented on PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#issuecomment-1439338678
I have checked out CI failed. I need to install the `pyflink` module in Python of the CI environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #3779: [KYUUBI #3773][FLINK] Support Flink Python UDF
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #3779:
URL: https://github.com/apache/kyuubi/pull/3779#discussion_r1114085293
##########
.github/workflows/master.yml:
##########
@@ -182,6 +182,14 @@ jobs:
java-version: ${{ matrix.java }}
cache: 'maven'
check-latest: false
+ - name: Setup Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: '3.8'
Review Comment:
Does pyflink support python 3.9? we use python 3.9 for pyspark, we'd better use the same version if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org