You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/02/05 18:44:13 UTC

[GitHub] [cassandra] dineshjoshi opened a new pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh

dineshjoshi opened a new pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh
URL: https://github.com/apache/cassandra/pull/438
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh

Posted by GitBox <gi...@apache.org>.
ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh
URL: https://github.com/apache/cassandra/pull/438#discussion_r375603889
 
 

 ##########
 File path: bin/cqlsh.py
 ##########
 @@ -140,10 +139,17 @@ def find_zip(libprefix):
     if lib_zip:
         sys.path.insert(0, lib_zip)
 
+import six
+
+from six.moves import configparser
+from six import StringIO
+from six.moves import input
+from six import ensure_text, ensure_str
 
 Review comment:
   These imports could be condensed:
   ```from six import StringIO, ensure_str, ensure_text
   from six.moves import configparser, input```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh

Posted by GitBox <gi...@apache.org>.
ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh
URL: https://github.com/apache/cassandra/pull/438#discussion_r375603889
 
 

 ##########
 File path: bin/cqlsh.py
 ##########
 @@ -140,10 +139,17 @@ def find_zip(libprefix):
     if lib_zip:
         sys.path.insert(0, lib_zip)
 
+import six
+
+from six.moves import configparser
+from six import StringIO
+from six.moves import input
+from six import ensure_text, ensure_str
 
 Review comment:
   These imports could be condensed:
   `from six import StringIO, ensure_str, ensure_text
   from six.moves import configparser, input`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] dineshjoshi closed pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh

Posted by GitBox <gi...@apache.org>.
dineshjoshi closed pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh
URL: https://github.com/apache/cassandra/pull/438
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] dcapwell commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh

Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh
URL: https://github.com/apache/cassandra/pull/438#discussion_r376128165
 
 

 ##########
 File path: .circleci/config-2_1.yml
 ##########
 @@ -138,6 +138,46 @@ j8_with_dtests_jobs: &j8_with_dtests_jobs
     - j8_upgradetests-no-vnodes:
         requires:
           - start_upgrade_tests
+    - start_j8_cqlsh_tests-with-vnodes:
 
 Review comment:
   I do wish we had a better way to maintain this =(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh

Posted by GitBox <gi...@apache.org>.
ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh
URL: https://github.com/apache/cassandra/pull/438#discussion_r375604270
 
 

 ##########
 File path: bin/cqlsh.py
 ##########
 @@ -216,8 +222,10 @@ def find_zip(libprefix):
 parser.add_option("-f", "--file", help="Execute commands from FILE, then exit")
 parser.add_option('--debug', action='store_true',
                   help='Show additional debugging information')
-parser.add_option("--encoding", help="Specify a non-default encoding for output." +
-                  " (Default: %s)" % (UTF8,))
+parser.add_option('--coverage', action='store_true',
+                  help='Collect coverage data')
+parser.add_option("--encoding", help="Specify a non-default encoding for output."
+                  + " (Default: %s)" % (UTF8,))
 
 Review comment:
   User specified encoding is a great addition.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh

Posted by GitBox <gi...@apache.org>.
ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh
URL: https://github.com/apache/cassandra/pull/438#discussion_r375603889
 
 

 ##########
 File path: bin/cqlsh.py
 ##########
 @@ -140,10 +139,17 @@ def find_zip(libprefix):
     if lib_zip:
         sys.path.insert(0, lib_zip)
 
+import six
+
+from six.moves import configparser
+from six import StringIO
+from six.moves import input
+from six import ensure_text, ensure_str
 
 Review comment:
   These imports could be condensed:
   `from six import StringIO, ensure_str, ensure_text`
   `from six.moves import configparser, input`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh

Posted by GitBox <gi...@apache.org>.
ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh
URL: https://github.com/apache/cassandra/pull/438#discussion_r375604270
 
 

 ##########
 File path: bin/cqlsh.py
 ##########
 @@ -216,8 +222,10 @@ def find_zip(libprefix):
 parser.add_option("-f", "--file", help="Execute commands from FILE, then exit")
 parser.add_option('--debug', action='store_true',
                   help='Show additional debugging information')
-parser.add_option("--encoding", help="Specify a non-default encoding for output." +
-                  " (Default: %s)" % (UTF8,))
+parser.add_option('--coverage', action='store_true',
+                  help='Collect coverage data')
+parser.add_option("--encoding", help="Specify a non-default encoding for output."
+                  + " (Default: %s)" % (UTF8,))
 
 Review comment:
   User specified encoding is a great addition.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh

Posted by GitBox <gi...@apache.org>.
ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh
URL: https://github.com/apache/cassandra/pull/438#discussion_r375611600
 
 

 ##########
 File path: pylib/cqlshlib/test/ansi_colors.py
 ##########
 @@ -14,31 +14,36 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+from __future__ import unicode_literals
+
 import re
+import six
+
+LIGHT = 0o10
 
-LIGHT = 010
 
-ansi_CSI = '\033['
+#ansi_CSI = '\033['
 
 Review comment:
   Should remove this commented out line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org