You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "AthiraHari77 (via GitHub)" <gi...@apache.org> on 2025/09/26 13:19:51 UTC

[I] Refactor DMNCompilerImpl.getId to clarify behavior [incubator-kie-issues]

AthiraHari77 opened a new issue, #2118:
URL: https://github.com/apache/incubator-kie-issues/issues/2118

   The current method **DMNCompilerImpl.getId(DMNElementReference)** behaves correctly but its name is misleading. It conditionally strips the prepended namespace from the href — depending on whether the reference is local or imported — which is not immediately clear from its name. This can lead to confusion or misuse, especially in scenarios involving imported DMN models.
   
   To improve clarity and maintainability:
   
   Rename the method to better reflect its conditional behavior.
   Add tests to cover both local and imported reference scenarios, ensuring correct behavior when the namespace is present or absent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] Refactor DMNCompilerImpl.getId Method to clarify behavior [incubator-kie-issues]

Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer closed issue #2118: Refactor DMNCompilerImpl.getId Method to clarify behavior
URL: https://github.com/apache/incubator-kie-issues/issues/2118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org