You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/05/26 22:41:45 UTC
[kudu-CR] [client-test] gscoped ptr --> unique ptr
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7002
Change subject: [client-test] gscoped_ptr --> unique_ptr
......................................................................
[client-test] gscoped_ptr --> unique_ptr
Replace gscoped_ptr with std::unique_ptr in the client-test and
corresponding parts of the Kudu C++ client implementation.
This patch does not contain any functional changes.
Change-Id: If7301b8c830837deaf487c1e0c9b711db72b767a
---
M src/kudu/client/batcher.cc
M src/kudu/client/client-test.cc
M src/kudu/client/error_collector.cc
M src/kudu/client/error_collector.h
M src/kudu/client/session-internal.cc
5 files changed, 80 insertions(+), 83 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/7002/1
--
To view, visit http://gerrit.cloudera.org:8080/7002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7301b8c830837deaf487c1e0c9b711db72b767a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client-test] gscoped ptr --> unique ptr
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [client-test] gscoped_ptr --> unique_ptr
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7301b8c830837deaf487c1e0c9b711db72b767a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [client-test] gscoped ptr --> unique ptr
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [client-test] gscoped_ptr --> unique_ptr
......................................................................
[client-test] gscoped_ptr --> unique_ptr
Replace gscoped_ptr with std::unique_ptr in the client-test and
corresponding parts of the Kudu C++ client implementation.
This patch does not contain any functional changes.
Change-Id: If7301b8c830837deaf487c1e0c9b711db72b767a
Reviewed-on: http://gerrit.cloudera.org:8080/7002
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/batcher.cc
M src/kudu/client/client-test.cc
M src/kudu/client/error_collector.cc
M src/kudu/client/error_collector.h
M src/kudu/client/session-internal.cc
5 files changed, 80 insertions(+), 83 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7301b8c830837deaf487c1e0c9b711db72b767a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client-test] gscoped ptr --> unique ptr
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [client-test] gscoped_ptr --> unique_ptr
......................................................................
Patch Set 1: Verified+1
Unrelated flake org.apache.kudu.spark.kudu.DefaultSourceTest
It seems it has been around for about a month already.
--
To view, visit http://gerrit.cloudera.org:8080/7002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7301b8c830837deaf487c1e0c9b711db72b767a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-HasComments: No