You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dineshkumar Yadav <di...@outlook.com> on 2020/01/16 15:09:04 UTC
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/
-----------------------------------------------------------
(Updated Jan. 16, 2020, 3:09 p.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
Bugs: RANGER-2699
https://issues.apache.org/jira/browse/RANGER-2699
Repository: ranger
Description
-------
Added metrics information in usersync and tagsync services
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java 6d27b02cd
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
tagsync/src/main/resources/ranger-tagsync-site.xml 9a14c1cc7
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 1d4e37fcf
ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
ugsync/src/test/resources/ranger-ugsync-site.xml 0a1a86da0
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
Diff: https://reviews.apache.org/r/71993/diff/4/
Testing
-------
Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
I have kept below parameter configurable
1. Metircs Name (Default value metrics.json)
2. Metrics Diroctory (must have write permission and defualt value /tmp/)
3. frequency at metrics get updated (defualt value: 10 sec)
4. metrics enbaled or disabled
Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
Thanks,
Dineshkumar Yadav
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Dineshkumar Yadav <di...@outlook.com>.
> On Jan. 27, 2020, 12:51 p.m., Pradeep Agrawal wrote:
> > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java
> > Lines 33 (patched)
> > <https://reviews.apache.org/r/71993/diff/9/?file=2209687#file2209687line33>
> >
> > any specific reason for not calling start() method here using run()
main method I have created for testing run method locally. It's not been called anywhere.
- Dineshkumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/#review219381
-----------------------------------------------------------
On Jan. 28, 2020, 9:56 a.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71993/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2020, 9:56 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
>
>
> Bugs: RANGER-2699
> https://issues.apache.org/jira/browse/RANGER-2699
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added metrics information in usersync and tagsync services
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
> tagsync/conf/templates/ranger-tagsync-template.xml b8bfbf510
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java c4173da68
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
> tagsync/src/main/resources/ranger-tagsync-default.xml 1034bc6e5
> tagsync/src/main/resources/ranger-tagsync-site.xml 0b9ef8492
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java a041345cf
> ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
> unixauthservice/conf.dist/ranger-ugsync-default.xml 0f88aa3f3
> unixauthservice/scripts/templates/ranger-ugsync-template.xml 0cacc954b
> unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
>
>
> Diff: https://reviews.apache.org/r/71993/diff/10/
>
>
> Testing
> -------
>
> Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
> I have kept below parameter configurable
> 1. Metrics Name (Default value metrics.json)
> 2. Metrics Directory (must have write permission and default value /tmp/)
> 3. frequency at metrics get updated (default value: 10 sec)
> 4. metrics enabled or disabled
> Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/#review219381
-----------------------------------------------------------
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java
Lines 33 (patched)
<https://reviews.apache.org/r/71993/#comment307553>
any specific reason for not calling start() method here using run()
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
Lines 246 (patched)
<https://reviews.apache.org/r/71993/#comment307552>
Can you change default name of different modules.
it can be ranger_usersync_metric.json here.
- Pradeep Agrawal
On Jan. 27, 2020, 10:46 a.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71993/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2020, 10:46 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
>
>
> Bugs: RANGER-2699
> https://issues.apache.org/jira/browse/RANGER-2699
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added metrics information in usersync and tagsync services
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
> tagsync/conf/templates/ranger-tagsync-template.xml b8bfbf510
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java c4173da68
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
> tagsync/src/main/resources/ranger-tagsync-default.xml 1034bc6e5
> tagsync/src/main/resources/ranger-tagsync-site.xml 0b9ef8492
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java a041345cf
> ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
> unixauthservice/conf.dist/ranger-ugsync-default.xml 0f88aa3f3
> unixauthservice/scripts/templates/ranger-ugsync-template.xml 0cacc954b
> unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
>
>
> Diff: https://reviews.apache.org/r/71993/diff/9/
>
>
> Testing
> -------
>
> Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
> I have kept below parameter configurable
> 1. Metrics Name (Default value metrics.json)
> 2. Metrics Directory (must have write permission and default value /tmp/)
> 3. frequency at metrics get updated (default value: 10 sec)
> 4. metrics enabled or disabled
> Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/#review219400
-----------------------------------------------------------
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
Lines 1073 (patched)
<https://reviews.apache.org/r/71993/#comment307567>
try to read first from "ranger.usersync.logdir" property. if not available then read from system environment
- Pradeep Agrawal
On Jan. 28, 2020, 9:56 a.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71993/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2020, 9:56 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
>
>
> Bugs: RANGER-2699
> https://issues.apache.org/jira/browse/RANGER-2699
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added metrics information in usersync and tagsync services
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
> tagsync/conf/templates/ranger-tagsync-template.xml b8bfbf510
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java c4173da68
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
> tagsync/src/main/resources/ranger-tagsync-default.xml 1034bc6e5
> tagsync/src/main/resources/ranger-tagsync-site.xml 0b9ef8492
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java a041345cf
> ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
> unixauthservice/conf.dist/ranger-ugsync-default.xml 0f88aa3f3
> unixauthservice/scripts/templates/ranger-ugsync-template.xml 0cacc954b
> unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
>
>
> Diff: https://reviews.apache.org/r/71993/diff/10/
>
>
> Testing
> -------
>
> Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
> I have kept below parameter configurable
> 1. Metrics Name (Default value metrics.json)
> 2. Metrics Directory (must have write permission and default value /tmp/)
> 3. frequency at metrics get updated (default value: 10 sec)
> 4. metrics enabled or disabled
> Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/#review219535
-----------------------------------------------------------
Ship it!
Ship It!
- Pradeep Agrawal
On Feb. 5, 2020, 2:49 p.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71993/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2020, 2:49 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
>
>
> Bugs: RANGER-2699
> https://issues.apache.org/jira/browse/RANGER-2699
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added metrics information in usersync and tagsync services
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
> tagsync/conf/templates/installprop2xml.properties 510cd6f44
> tagsync/conf/templates/ranger-tagsync-template.xml b8bfbf510
> tagsync/scripts/install.properties be33cc274
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java c4173da68
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
> tagsync/src/main/resources/ranger-tagsync-site.xml 0b9ef8492
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java a041345cf
> ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
> unixauthservice/scripts/install.properties d4c651308
> unixauthservice/scripts/templates/installprop2xml.properties fa342fbff
> unixauthservice/scripts/templates/ranger-ugsync-template.xml 0cacc954b
> unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
>
>
> Diff: https://reviews.apache.org/r/71993/diff/11/
>
>
> Testing
> -------
>
> Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
> I have kept below parameter configurable
> 1. Metrics Name (Default value ranger_tagsync_metric.json and ranger_usersync_metric.json)
> 2. Metrics Directory (must have write permission and default value is logdir)
> 3. frequency at metrics get updated (default value: 10 sec)
> 4. metrics enabled or disabled (default is disabled)
> Checked for ranger_tagsync_metric.json and ranger_usersync_metric.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/
-----------------------------------------------------------
(Updated Feb. 5, 2020, 2:49 p.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
Changes
-------
accepting config values from install.properties
Bugs: RANGER-2699
https://issues.apache.org/jira/browse/RANGER-2699
Repository: ranger
Description
-------
Added metrics information in usersync and tagsync services
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
tagsync/conf/templates/installprop2xml.properties 510cd6f44
tagsync/conf/templates/ranger-tagsync-template.xml b8bfbf510
tagsync/scripts/install.properties be33cc274
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java c4173da68
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
tagsync/src/main/resources/ranger-tagsync-site.xml 0b9ef8492
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java a041345cf
ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
unixauthservice/scripts/install.properties d4c651308
unixauthservice/scripts/templates/installprop2xml.properties fa342fbff
unixauthservice/scripts/templates/ranger-ugsync-template.xml 0cacc954b
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
Diff: https://reviews.apache.org/r/71993/diff/11/
Changes: https://reviews.apache.org/r/71993/diff/10-11/
Testing (updated)
-------
Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
I have kept below parameter configurable
1. Metrics Name (Default value ranger_tagsync_metric.json and ranger_usersync_metric.json)
2. Metrics Directory (must have write permission and default value is logdir)
3. frequency at metrics get updated (default value: 10 sec)
4. metrics enabled or disabled (default is disabled)
Checked for ranger_tagsync_metric.json and ranger_usersync_metric.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
Thanks,
Dineshkumar Yadav
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/
-----------------------------------------------------------
(Updated Jan. 28, 2020, 9:56 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
Changes
-------
changed default name form merics.json to "ranger_usersync_metric.json" for usersync and "ranger_tagsync_metric.json" tagsync.
Bugs: RANGER-2699
https://issues.apache.org/jira/browse/RANGER-2699
Repository: ranger
Description
-------
Added metrics information in usersync and tagsync services
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
tagsync/conf/templates/ranger-tagsync-template.xml b8bfbf510
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java c4173da68
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
tagsync/src/main/resources/ranger-tagsync-default.xml 1034bc6e5
tagsync/src/main/resources/ranger-tagsync-site.xml 0b9ef8492
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java a041345cf
ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
unixauthservice/conf.dist/ranger-ugsync-default.xml 0f88aa3f3
unixauthservice/scripts/templates/ranger-ugsync-template.xml 0cacc954b
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
Diff: https://reviews.apache.org/r/71993/diff/10/
Changes: https://reviews.apache.org/r/71993/diff/9-10/
Testing
-------
Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
I have kept below parameter configurable
1. Metrics Name (Default value metrics.json)
2. Metrics Directory (must have write permission and default value /tmp/)
3. frequency at metrics get updated (default value: 10 sec)
4. metrics enabled or disabled
Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
Thanks,
Dineshkumar Yadav
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/
-----------------------------------------------------------
(Updated Jan. 27, 2020, 10:46 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
Changes
-------
resolved metrics location related issue
Bugs: RANGER-2699
https://issues.apache.org/jira/browse/RANGER-2699
Repository: ranger
Description
-------
Added metrics information in usersync and tagsync services
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
tagsync/conf/templates/ranger-tagsync-template.xml b8bfbf510
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java c4173da68
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
tagsync/src/main/resources/ranger-tagsync-default.xml 1034bc6e5
tagsync/src/main/resources/ranger-tagsync-site.xml 0b9ef8492
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java a041345cf
ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
unixauthservice/conf.dist/ranger-ugsync-default.xml 0f88aa3f3
unixauthservice/scripts/templates/ranger-ugsync-template.xml 0cacc954b
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
Diff: https://reviews.apache.org/r/71993/diff/9/
Changes: https://reviews.apache.org/r/71993/diff/8-9/
Testing
-------
Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
I have kept below parameter configurable
1. Metrics Name (Default value metrics.json)
2. Metrics Directory (must have write permission and default value /tmp/)
3. frequency at metrics get updated (default value: 10 sec)
4. metrics enabled or disabled
Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
Thanks,
Dineshkumar Yadav
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/
-----------------------------------------------------------
(Updated Jan. 24, 2020, 9:23 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
Changes
-------
added property in ranger-tagsync-default.xml , ranger-tagsync-site.xml, ranger-ugsync-default.xml and ranger-ugsync-template.xml
Bugs: RANGER-2699
https://issues.apache.org/jira/browse/RANGER-2699
Repository: ranger
Description
-------
Added metrics information in usersync and tagsync services
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
tagsync/conf/templates/ranger-tagsync-template.xml b8bfbf510
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java c4173da68
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
tagsync/src/main/resources/ranger-tagsync-default.xml 1034bc6e5
tagsync/src/main/resources/ranger-tagsync-site.xml 0b9ef8492
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java a041345cf
ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
unixauthservice/conf.dist/ranger-ugsync-default.xml 0f88aa3f3
unixauthservice/scripts/templates/ranger-ugsync-template.xml 0cacc954b
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
Diff: https://reviews.apache.org/r/71993/diff/8/
Changes: https://reviews.apache.org/r/71993/diff/7-8/
Testing
-------
Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
I have kept below parameter configurable
1. Metrics Name (Default value metrics.json)
2. Metrics Directory (must have write permission and default value /tmp/)
3. frequency at metrics get updated (default value: 10 sec)
4. metrics enabled or disabled
Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
Thanks,
Dineshkumar Yadav
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/
-----------------------------------------------------------
(Updated Jan. 23, 2020, 11:34 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
Bugs: RANGER-2699
https://issues.apache.org/jira/browse/RANGER-2699
Repository: ranger
Description
-------
Added metrics information in usersync and tagsync services
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java c4173da68
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
tagsync/src/main/resources/ranger-tagsync-site.xml 0b9ef8492
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java a041345cf
ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
ugsync/src/test/resources/ranger-ugsync-site.xml 0a1a86da0
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
Diff: https://reviews.apache.org/r/71993/diff/7/
Changes: https://reviews.apache.org/r/71993/diff/6-7/
Testing
-------
Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
I have kept below parameter configurable
1. Metrics Name (Default value metrics.json)
2. Metrics Directory (must have write permission and default value /tmp/)
3. frequency at metrics get updated (default value: 10 sec)
4. metrics enabled or disabled
Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
Thanks,
Dineshkumar Yadav
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/#review219363
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Jan. 22, 2020, 8:24 a.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71993/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2020, 8:24 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
>
>
> Bugs: RANGER-2699
> https://issues.apache.org/jira/browse/RANGER-2699
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added metrics information in usersync and tagsync services
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java 6d27b02cd
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
> tagsync/src/main/resources/ranger-tagsync-site.xml 9a14c1cc7
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 1d4e37fcf
> ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
> ugsync/src/test/resources/ranger-ugsync-site.xml 0a1a86da0
> unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
>
>
> Diff: https://reviews.apache.org/r/71993/diff/6/
>
>
> Testing
> -------
>
> Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
> I have kept below parameter configurable
> 1. Metrics Name (Default value metrics.json)
> 2. Metrics Directory (must have write permission and default value /tmp/)
> 3. frequency at metrics get updated (default value: 10 sec)
> 4. metrics enabled or disabled
> Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/
-----------------------------------------------------------
(Updated Jan. 22, 2020, 8:24 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
Bugs: RANGER-2699
https://issues.apache.org/jira/browse/RANGER-2699
Repository: ranger
Description
-------
Added metrics information in usersync and tagsync services
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java 6d27b02cd
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
tagsync/src/main/resources/ranger-tagsync-site.xml 9a14c1cc7
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 1d4e37fcf
ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
ugsync/src/test/resources/ranger-ugsync-site.xml 0a1a86da0
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
Diff: https://reviews.apache.org/r/71993/diff/6/
Changes: https://reviews.apache.org/r/71993/diff/5-6/
Testing
-------
Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
I have kept below parameter configurable
1. Metrics Name (Default value metrics.json)
2. Metrics Directory (must have write permission and default value /tmp/)
3. frequency at metrics get updated (default value: 10 sec)
4. metrics enabled or disabled
Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
Thanks,
Dineshkumar Yadav
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/#review219347
-----------------------------------------------------------
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java
Lines 110 (patched)
<https://reviews.apache.org/r/71993/#comment307488>
Please consider inserting the unit (milliseconds) in the property name here and in usersync property name.
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java
Lines 45 (patched)
<https://reviews.apache.org/r/71993/#comment307491>
Please consider removing this check if the thread is not started at all when metrics collection is disabled.
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java
Lines 141 (patched)
<https://reviews.apache.org/r/71993/#comment307490>
If the metrics collection is disabled, is there any reason to create TagSyncMetricsProducer object and run it in the thread?
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java
Lines 143 (patched)
<https://reviews.apache.org/r/71993/#comment307489>
Please ensure that the thread is a damon thread. Please see TagAdminRESTSink.start() for reference.
- Abhay Kulkarni
On Jan. 21, 2020, 7:14 a.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71993/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2020, 7:14 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
>
>
> Bugs: RANGER-2699
> https://issues.apache.org/jira/browse/RANGER-2699
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added metrics information in usersync and tagsync services
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java 6d27b02cd
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
> tagsync/src/main/resources/ranger-tagsync-site.xml 9a14c1cc7
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 1d4e37fcf
> ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
> ugsync/src/test/resources/ranger-ugsync-site.xml 0a1a86da0
> unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
>
>
> Diff: https://reviews.apache.org/r/71993/diff/5/
>
>
> Testing
> -------
>
> Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
> I have kept below parameter configurable
> 1. Metrics Name (Default value metrics.json)
> 2. Metrics Directory (must have write permission and default value /tmp/)
> 3. frequency at metrics get updated (default value: 10 sec)
> 4. metrics enabled or disabled
> Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/
-----------------------------------------------------------
(Updated Jan. 21, 2020, 7:14 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
Bugs: RANGER-2699
https://issues.apache.org/jira/browse/RANGER-2699
Repository: ranger
Description
-------
Added metrics information in usersync and tagsync services
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java 6d27b02cd
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
tagsync/src/main/resources/ranger-tagsync-site.xml 9a14c1cc7
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 1d4e37fcf
ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
ugsync/src/test/resources/ranger-ugsync-site.xml 0a1a86da0
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
Diff: https://reviews.apache.org/r/71993/diff/5/
Changes: https://reviews.apache.org/r/71993/diff/4-5/
Testing
-------
Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
I have kept below parameter configurable
1. Metrics Name (Default value metrics.json)
2. Metrics Directory (must have write permission and default value /tmp/)
3. frequency at metrics get updated (default value: 10 sec)
4. metrics enabled or disabled
Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
Thanks,
Dineshkumar Yadav
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/#review219338
-----------------------------------------------------------
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java
Lines 42 (patched)
<https://reviews.apache.org/r/71993/#comment307480>
Seams there is indentation issue, can you check the same again at all the places in your patch
- Pradeep Agrawal
On Jan. 17, 2020, 6:46 a.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71993/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2020, 6:46 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
>
>
> Bugs: RANGER-2699
> https://issues.apache.org/jira/browse/RANGER-2699
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added metrics information in usersync and tagsync services
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java 6d27b02cd
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
> tagsync/src/main/resources/ranger-tagsync-site.xml 9a14c1cc7
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 1d4e37fcf
> ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
> ugsync/src/test/resources/ranger-ugsync-site.xml 0a1a86da0
> unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
>
>
> Diff: https://reviews.apache.org/r/71993/diff/4/
>
>
> Testing
> -------
>
> Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
> I have kept below parameter configurable
> 1. Metrics Name (Default value metrics.json)
> 2. Metrics Directory (must have write permission and default value /tmp/)
> 3. frequency at metrics get updated (default value: 10 sec)
> 4. metrics enabled or disabled
> Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 71993: RANGER-2699 : JVM metrics for Ranger
usersync and Ranger tagsync
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/
-----------------------------------------------------------
(Updated Jan. 17, 2020, 6:46 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
Bugs: RANGER-2699
https://issues.apache.org/jira/browse/RANGER-2699
Repository: ranger
Description
-------
Added metrics information in usersync and tagsync services
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java 6d27b02cd
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncMetricsProducer.java PRE-CREATION
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 8806c7469
tagsync/src/main/resources/ranger-tagsync-site.xml 9a14c1cc7
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 1d4e37fcf
ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java PRE-CREATION
ugsync/src/test/resources/ranger-ugsync-site.xml 0a1a86da0
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 1ee5e21ba
Diff: https://reviews.apache.org/r/71993/diff/4/
Testing (updated)
-------
Validated metrics which are getting generated at configured interval when usersync and tagsync services start.
I have kept below parameter configurable
1. Metrics Name (Default value metrics.json)
2. Metrics Directory (must have write permission and default value /tmp/)
3. frequency at metrics get updated (default value: 10 sec)
4. metrics enabled or disabled
Checked for metrics.json being regularly updated based on JVM resources utilization. Validated for usersync as well as tagsync process.
Thanks,
Dineshkumar Yadav