You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2015/03/05 20:39:05 UTC
Re: Review Request 30841: Remove static strings and split process.cpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30841/
-----------------------------------------------------------
(Updated March 5, 2015, 11:39 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
rebased
Bugs: MESOS-1023
https://issues.apache.org/jira/browse/MESOS-1023
Repository: mesos
Description
-------
Remove static strings from process
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
3rdparty/libprocess/include/process/logging.hpp 122022343ccba433fecfc6ff548e8fa3d9bdca6b
3rdparty/libprocess/include/process/profiler.hpp c886d7e7e4effb10c661a4b7141686432255b370
3rdparty/libprocess/src/logging.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
3rdparty/libprocess/src/profiler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/30841/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 30841: Remove static strings and split process.cpp
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30841/#review75449
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30841]
All tests passed.
- Mesos ReviewBot
On March 5, 2015, 7:39 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30841/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 7:39 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1023
> https://issues.apache.org/jira/browse/MESOS-1023
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove static strings from process
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
> 3rdparty/libprocess/include/process/logging.hpp 122022343ccba433fecfc6ff548e8fa3d9bdca6b
> 3rdparty/libprocess/include/process/profiler.hpp c886d7e7e4effb10c661a4b7141686432255b370
> 3rdparty/libprocess/src/logging.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
> 3rdparty/libprocess/src/profiler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30841/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 30841: Remove static strings and split process.cpp
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30841/#review75750
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 9, 2015, 7:16 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30841/
> -----------------------------------------------------------
>
> (Updated March 9, 2015, 7:16 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1023
> https://issues.apache.org/jira/browse/MESOS-1023
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove static strings from process
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
> 3rdparty/libprocess/include/process/logging.hpp 122022343ccba433fecfc6ff548e8fa3d9bdca6b
> 3rdparty/libprocess/include/process/profiler.hpp c886d7e7e4effb10c661a4b7141686432255b370
> 3rdparty/libprocess/src/logging.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 0b3ce9fc7bf183ffc2b8a6d0b7ce06767841cfcd
> 3rdparty/libprocess/src/profiler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30841/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 30841: Remove static strings and split process.cpp
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30841/
-----------------------------------------------------------
(Updated March 9, 2015, 12:16 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-1023
https://issues.apache.org/jira/browse/MESOS-1023
Repository: mesos
Description
-------
Remove static strings from process
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
3rdparty/libprocess/include/process/logging.hpp 122022343ccba433fecfc6ff548e8fa3d9bdca6b
3rdparty/libprocess/include/process/profiler.hpp c886d7e7e4effb10c661a4b7141686432255b370
3rdparty/libprocess/src/logging.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 0b3ce9fc7bf183ffc2b8a6d0b7ce06767841cfcd
3rdparty/libprocess/src/profiler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/30841/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 30841: Remove static strings and split process.cpp
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30841/#review75734
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30841]
All tests passed.
- Mesos ReviewBot
On March 9, 2015, 5:26 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30841/
> -----------------------------------------------------------
>
> (Updated March 9, 2015, 5:26 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1023
> https://issues.apache.org/jira/browse/MESOS-1023
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove static strings from process
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
> 3rdparty/libprocess/include/process/logging.hpp 122022343ccba433fecfc6ff548e8fa3d9bdca6b
> 3rdparty/libprocess/include/process/profiler.hpp c886d7e7e4effb10c661a4b7141686432255b370
> 3rdparty/libprocess/src/logging.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 0b3ce9fc7bf183ffc2b8a6d0b7ce06767841cfcd
> 3rdparty/libprocess/src/profiler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30841/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 30841: Remove static strings and split process.cpp
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30841/
-----------------------------------------------------------
(Updated March 9, 2015, 10:26 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
rebased and jie's comments
Bugs: MESOS-1023
https://issues.apache.org/jira/browse/MESOS-1023
Repository: mesos
Description
-------
Remove static strings from process
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
3rdparty/libprocess/include/process/logging.hpp 122022343ccba433fecfc6ff548e8fa3d9bdca6b
3rdparty/libprocess/include/process/profiler.hpp c886d7e7e4effb10c661a4b7141686432255b370
3rdparty/libprocess/src/logging.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 0b3ce9fc7bf183ffc2b8a6d0b7ce06767841cfcd
3rdparty/libprocess/src/profiler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/30841/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 30841: Remove static strings and split process.cpp
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30841/#review75719
-----------------------------------------------------------
Thanks for the cleanup.
3rdparty/libprocess/include/process/logging.hpp
<https://reviews.apache.org/r/30841/#comment122943>
Can you move headers that are not used in the header to the source file. For instance, Try, Option, numify, Duration, delay, etc.
3rdparty/libprocess/include/process/logging.hpp
<https://reviews.apache.org/r/30841/#comment122942>
Can you keep the old name to reflect the fact that the method returns a constant (more easy to understand at the callsites).
3rdparty/libprocess/include/process/profiler.hpp
<https://reviews.apache.org/r/30841/#comment122944>
Ditto here. Please keep the current names.
- Jie Yu
On March 5, 2015, 7:39 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30841/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 7:39 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1023
> https://issues.apache.org/jira/browse/MESOS-1023
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove static strings from process
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
> 3rdparty/libprocess/include/process/logging.hpp 122022343ccba433fecfc6ff548e8fa3d9bdca6b
> 3rdparty/libprocess/include/process/profiler.hpp c886d7e7e4effb10c661a4b7141686432255b370
> 3rdparty/libprocess/src/logging.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
> 3rdparty/libprocess/src/profiler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30841/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>