You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2025/02/26 13:29:58 UTC

(maven-project-info-reports-plugin) branch bugs created (now 7bd40db)

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a change to branch bugs
in repository https://gitbox.apache.org/repos/asf/maven-project-info-reports-plugin.git


      at 7bd40db  Remove moot operations

This branch includes the following new commits:

     new 7bd40db  Remove moot operations

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(maven-project-info-reports-plugin) 01/01: Remove moot operations

Posted by el...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch bugs
in repository https://gitbox.apache.org/repos/asf/maven-project-info-reports-plugin.git

commit 7bd40db8fc8e4730762c6659eba68f537117caea
Author: Elliotte Rusty Harold <el...@ibiblio.org>
AuthorDate: Wed Feb 26 08:29:49 2025 -0500

    Remove moot operations
---
 .../org/apache/maven/report/projectinfo/SummaryReport.java   | 12 ++----------
 .../dependencies/renderer/DependenciesRenderer.java          |  2 +-
 .../report/projectinfo/AbstractProjectInfoTestCase.java      |  7 +------
 .../maven/report/projectinfo/PluginManagementReportTest.java |  2 +-
 4 files changed, 5 insertions(+), 18 deletions(-)

diff --git a/src/main/java/org/apache/maven/report/projectinfo/SummaryReport.java b/src/main/java/org/apache/maven/report/projectinfo/SummaryReport.java
index dd5f196..9a06291 100644
--- a/src/main/java/org/apache/maven/report/projectinfo/SummaryReport.java
+++ b/src/main/java/org/apache/maven/report/projectinfo/SummaryReport.java
@@ -148,13 +148,7 @@ public class SummaryReport extends AbstractProjectInfoReport {
             String sourceConfigured = getPluginParameter(pluginId, "source");
             String targetConfigured = getPluginParameter(pluginId, "target");
 
-            String forkFlag = getPluginParameter(pluginId, "fork");
-            String compilerVersionConfigured = null;
-            if ("true".equalsIgnoreCase(forkFlag)) {
-                compilerVersionConfigured = getPluginParameter(pluginId, "compilerVersion");
-            }
-
-            String minimumJavaVersion = compilerVersionConfigured;
+            String minimumJavaVersion;
             if (targetConfigured != null) {
                 minimumJavaVersion = targetConfigured;
             } else if (sourceConfigured != null) {
@@ -162,8 +156,6 @@ public class SummaryReport extends AbstractProjectInfoReport {
             } else {
                 // ${maven.compiler.target} default value
                 minimumJavaVersion = project.getProperties().getProperty("maven.compiler.target");
-
-                // default to 1.5 if not set?
             }
 
             return minimumJavaVersion;
@@ -179,7 +171,7 @@ public class SummaryReport extends AbstractProjectInfoReport {
 
                 if (cell == null || cell.isEmpty()) {
                     sink.text("-");
-                } else if (ctr == content.length - 1 && cell.length() > 0) {
+                } else if (ctr == content.length - 1) {
                     sink.link(cell);
                     sink.text(cell);
                     sink.link_();
diff --git a/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java b/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
index dd0e6ea..ce48a98 100644
--- a/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
+++ b/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
@@ -281,7 +281,7 @@ public class DependenciesRenderer extends AbstractProjectInfoRenderer {
 
         startSection(getI18nString("transitive.title"));
 
-        if (dependenciesByScope.values().isEmpty()) {
+        if (dependenciesByScope.isEmpty()) {
             paragraph(getI18nString("transitive.nolist"));
         } else {
             paragraph(getI18nString("transitive.intro"));
diff --git a/src/test/java/org/apache/maven/report/projectinfo/AbstractProjectInfoTestCase.java b/src/test/java/org/apache/maven/report/projectinfo/AbstractProjectInfoTestCase.java
index 120555f..48dee21 100644
--- a/src/test/java/org/apache/maven/report/projectinfo/AbstractProjectInfoTestCase.java
+++ b/src/test/java/org/apache/maven/report/projectinfo/AbstractProjectInfoTestCase.java
@@ -57,7 +57,7 @@ public abstract class AbstractProjectInfoTestCase extends AbstractMojoTestCase {
     private ArtifactStubFactory artifactStubFactory;
 
     /**
-     * The current project to be test.
+     * The current project to be tested.
      */
     private MavenProject testMavenProject;
 
@@ -80,11 +80,6 @@ public abstract class AbstractProjectInfoTestCase extends AbstractMojoTestCase {
         artifactStubFactory.getWorkingDir().mkdirs();
     }
 
-    @Override
-    protected void tearDown() throws Exception {
-        super.tearDown();
-    }
-
     /**
      * Gets a trimmed String for the given key from the resource bundle defined by Plexus.
      *
diff --git a/src/test/java/org/apache/maven/report/projectinfo/PluginManagementReportTest.java b/src/test/java/org/apache/maven/report/projectinfo/PluginManagementReportTest.java
index eae4984..0ad6500 100644
--- a/src/test/java/org/apache/maven/report/projectinfo/PluginManagementReportTest.java
+++ b/src/test/java/org/apache/maven/report/projectinfo/PluginManagementReportTest.java
@@ -59,7 +59,7 @@ public class PluginManagementReportTest extends AbstractProjectInfoTestCase {
                 .thenAnswer(new Answer<ProjectBuildingResult>() {
                     @Override
                     public ProjectBuildingResult answer(InvocationOnMock invocation) throws Throwable {
-                        return createProjectBuildingResult((Artifact) invocation.getArgument(0), "http://m.a.o/");
+                        return createProjectBuildingResult(invocation.getArgument(0), "http://m.a.o/");
                     }
                 });