You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/12/26 02:04:54 UTC
[native-toolchain-CR] Correct Boost version for Thrift building
huangtianhua223@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14949
Change subject: Correct Boost version for Thrift building
......................................................................
Correct Boost version for Thrift building
Change-Id: Ie3a9beb1769e54ce12ab78f0699ae5a2d145e0f7
---
M buildall.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/49/14949/1
--
To view, visit http://gerrit.cloudera.org:8080/14949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3a9beb1769e54ce12ab78f0699ae5a2d145e0f7
Gerrit-Change-Number: 14949
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
[native-toolchain-CR] Correct Boost version for Thrift building
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14949 )
Change subject: Correct Boost version for Thrift building
......................................................................
Patch Set 1:
OK, thanks.
We bumped boost version in: https://gerrit.cloudera.org/#/c/14898/4/buildall.sh so I bump it for thrift building.
--
To view, visit http://gerrit.cloudera.org:8080/14949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a9beb1769e54ce12ab78f0699ae5a2d145e0f7
Gerrit-Change-Number: 14949
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jan 2020 08:55:24 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Correct Boost version for Thrift building
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14949 )
Change subject: Correct Boost version for Thrift building
......................................................................
Patch Set 1:
The impala tests failed with the new boost version, I think because of the patches from boost 1.57.0 that weren't applied to 1.61.0 (I incorrectly thought that the fixes were already present, when actually the first two patches were still needed)
I added the patches back in here:
https://github.com/timarmstrong/native-toolchain/tree/boost-thrift-bump . If you want to include my changes in this patch, that would be appreciated.
--
To view, visit http://gerrit.cloudera.org:8080/14949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a9beb1769e54ce12ab78f0699ae5a2d145e0f7
Gerrit-Change-Number: 14949
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 21:14:54 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Correct Boost version for Thrift building
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14949 )
Change subject: Correct Boost version for Thrift building
......................................................................
Patch Set 1:
@Tim,
Thanks very much, I will change this.
--
To view, visit http://gerrit.cloudera.org:8080/14949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a9beb1769e54ce12ab78f0699ae5a2d145e0f7
Gerrit-Change-Number: 14949
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jan 2020 02:35:24 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Correct Boost version for Thrift building
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14949 )
Change subject: Correct Boost version for Thrift building
......................................................................
Patch Set 1:
I think we probably need to test this with Impala on x86-64 first to make sure that it doesn't break anything - I don't know if there are any compatibility issues if thrift is compiled with a different boost version from Impala (we might be better off bumping the boost version anyway, which also requries running tests).
I'm currently on vacation and can do this when I get back - otherwise maybe someone else can take a look.
--
To view, visit http://gerrit.cloudera.org:8080/14949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a9beb1769e54ce12ab78f0699ae5a2d145e0f7
Gerrit-Change-Number: 14949
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jan 2020 12:15:06 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Correct Boost version for Thrift building
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14949 )
Change subject: Correct Boost version for Thrift building
......................................................................
Patch Set 1:
I'm getting back to this. I'll build a toolchain with this patch and run Impala's tests.
--
To view, visit http://gerrit.cloudera.org:8080/14949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a9beb1769e54ce12ab78f0699ae5a2d145e0f7
Gerrit-Change-Number: 14949
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 01:03:40 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Correct Boost version for Thrift building
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/14949 )
Change subject: Correct Boost version for Thrift building
......................................................................
Abandoned
Abandon this, see new patch https://gerrit.cloudera.org/#/c/15095/
--
To view, visit http://gerrit.cloudera.org:8080/14949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie3a9beb1769e54ce12ab78f0699ae5a2d145e0f7
Gerrit-Change-Number: 14949
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>