You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/22 09:33:12 UTC
[GitHub] [arrow] tianchen92 commented on a change in pull request #7496: ARROW-7084: [C++] ArrayRangeEquals should check for full type equality?
tianchen92 commented on a change in pull request #7496:
URL: https://github.com/apache/arrow/pull/7496#discussion_r443433850
##########
File path: cpp/src/arrow/compare.cc
##########
@@ -984,7 +984,8 @@ bool ArrayRangeEquals(const Array& left, const Array& right, int64_t left_start_
bool are_equal;
if (&left == &right) {
are_equal = true;
- } else if (left.type_id() != right.type_id()) {
+ } else if (left.type_id() != right.type_id() ||
+ !TypeEquals(*left.type(), *right.type(), false /* check_metadata */)) {
Review comment:
Thanks wes, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org