You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by galen-pivotal <gi...@git.apache.org> on 2017/07/13 21:57:53 UTC
[GitHub] geode pull request #633: GEODE-3170: Closed socket doesn't result in an infi...
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/633
GEODE-3170: Closed socket doesn't result in an infinite loop.
* Protobuf deserialization returning null is handled.
* IOException causes GenericProtocolServerConnection to close.
* Added a couple of JUnit tests.
Signed-off-by: Hitesh Khamesra <hk...@pivotal.io>
Signed-off-by: Galen O'Sullivan <go...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/galen-pivotal/geode feature/GEODE-3170
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/633.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #633
----
commit c13797630d4a7825e8ab7c668a521fd3a3aeff77
Author: Galen O'Sullivan <go...@pivotal.io>
Date: 2017-07-13T18:26:09Z
GEODE-3170: Closed socket doesn't result in an infinite loop.
* Protobuf deserialization returning null is handled.
* IOException causes GenericProtocolServerConnection to close.
* Added a couple of JUnit tests.
Signed-off-by: Hitesh Khamesra <hk...@pivotal.io>
Signed-off-by: Galen O'Sullivan <go...@pivotal.io>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #633: GEODE-3170: Closed socket doesn't result in an infi...
Posted by galen-pivotal <gi...@git.apache.org>.
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/633#discussion_r127550540
--- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java ---
@@ -68,9 +56,8 @@ protected void doOneMessage() {
messageHandler.receiveMessage(inputStream, outputStream, this.getCache());
} catch (IOException e) {
logger.warn(e);
- // TODO?
+ this.setFlagProcessMessagesAsFalse(); // TODO: better shutdown.
--- End diff --
https://issues.apache.org/jira/browse/GEODE-3079 should cover it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #633: GEODE-3170: Closed socket doesn't result in an infi...
Posted by kohlmu-pivotal <gi...@git.apache.org>.
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/633#discussion_r127540044
--- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java ---
@@ -68,9 +56,8 @@ protected void doOneMessage() {
messageHandler.receiveMessage(inputStream, outputStream, this.getCache());
} catch (IOException e) {
logger.warn(e);
- // TODO?
+ this.setFlagProcessMessagesAsFalse(); // TODO: better shutdown.
--- End diff --
Can we raise a ticket for this to complete this TODO
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #633: GEODE-3170: Closed socket doesn't result in an infinite lo...
Posted by kohlmu-pivotal <gi...@git.apache.org>.
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/633
@hiteshk25 @pivotal-amurmann
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #633: GEODE-3170: Closed socket doesn't result in an infi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/633
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---