You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Alejandro Abdelnur (Created) (JIRA)" <ji...@apache.org> on 2011/11/21 22:26:52 UTC

[jira] [Created] (OOZIE-607) Pig POM brings in several unneeded dependencies

Pig POM brings in several unneeded dependencies
-----------------------------------------------

                 Key: OOZIE-607
                 URL: https://issues.apache.org/jira/browse/OOZIE-607
             Project: Oozie
          Issue Type: Bug
            Reporter: Alejandro Abdelnur
            Assignee: Alejandro Abdelnur


Pig 0.9.0 brings many unneeded runtime dependencies (ie junit) and dependencies that should not be there (servlet API).

I've opened a JIRA for Pig (PIG-2373) but in the mean time we should take care of it in Oozie's sharelib POM

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OOZIE-607) Pig POM brings in several unneeded dependencies

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OOZIE-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154582#comment-13154582 ] 

jiraposter@reviews.apache.org commented on OOZIE-607:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2902/#review3407
-----------------------------------------------------------



/trunk/sharelib/pom.xml
<https://reviews.apache.org/r/2902/#comment7633>

    Can you explain why the scope is changed from runtime to compile?
    
    These libraries are picked at run time when pig related test cases are executed.
    They are not used during compilation.


- Virag


On 2011-11-21 21:29:01, Alejandro Abdelnur wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2902/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-21 21:29:01)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Excluding unneeded Pig dependencies. (Pig testcases pass)
bq.  
bq.  
bq.  This addresses bug OOZIE-607.
bq.      https://issues.apache.org/jira/browse/OOZIE-607
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/pom.xml 1204713 
bq.    /trunk/sharelib/pom.xml 1204713 
bq.  
bq.  Diff: https://reviews.apache.org/r/2902/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Alejandro
bq.  
bq.


                
> Pig POM brings in several unneeded dependencies
> -----------------------------------------------
>
>                 Key: OOZIE-607
>                 URL: https://issues.apache.org/jira/browse/OOZIE-607
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>
> Pig 0.9.0 brings many unneeded runtime dependencies (ie junit) and dependencies that should not be there (servlet API).
> I've opened a JIRA for Pig (PIG-2373) but in the mean time we should take care of it in Oozie's sharelib POM

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OOZIE-607) Pig POM brings in several unneeded dependencies

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OOZIE-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154844#comment-13154844 ] 

jiraposter@reviews.apache.org commented on OOZIE-607:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2902/#review3422
-----------------------------------------------------------

Ship it!


+1

- Mohammad


On 2011-11-21 22:32:23, Alejandro Abdelnur wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2902/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-21 22:32:23)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Excluding unneeded Pig dependencies. (Pig testcases pass)
bq.  
bq.  
bq.  This addresses bug OOZIE-607.
bq.      https://issues.apache.org/jira/browse/OOZIE-607
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/pom.xml 1204713 
bq.    /trunk/sharelib/pom.xml 1204713 
bq.  
bq.  Diff: https://reviews.apache.org/r/2902/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Alejandro
bq.  
bq.


                
> Pig POM brings in several unneeded dependencies
> -----------------------------------------------
>
>                 Key: OOZIE-607
>                 URL: https://issues.apache.org/jira/browse/OOZIE-607
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>
> Pig 0.9.0 brings many unneeded runtime dependencies (ie junit) and dependencies that should not be there (servlet API).
> I've opened a JIRA for Pig (PIG-2373) but in the mean time we should take care of it in Oozie's sharelib POM

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (OOZIE-607) Pig POM brings in several unneeded dependencies

Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OOZIE-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alejandro Abdelnur updated OOZIE-607:
-------------------------------------

    Fix Version/s: 3.2.0
    
> Pig POM brings in several unneeded dependencies
> -----------------------------------------------
>
>                 Key: OOZIE-607
>                 URL: https://issues.apache.org/jira/browse/OOZIE-607
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 3.2.0
>
>
> Pig 0.9.0 brings many unneeded runtime dependencies (ie junit) and dependencies that should not be there (servlet API).
> I've opened a JIRA for Pig (PIG-2373) but in the mean time we should take care of it in Oozie's sharelib POM

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OOZIE-607) Pig POM brings in several unneeded dependencies

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OOZIE-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154685#comment-13154685 ] 

jiraposter@reviews.apache.org commented on OOZIE-607:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2902/
-----------------------------------------------------------

(Updated 2011-11-21 22:32:23.495642)


Review request for oozie.


Changes
-------

updated patch changing  deps of pig from compile to runtime.


Summary
-------

Excluding unneeded Pig dependencies. (Pig testcases pass)


This addresses bug OOZIE-607.
    https://issues.apache.org/jira/browse/OOZIE-607


Diffs (updated)
-----

  /trunk/pom.xml 1204713 
  /trunk/sharelib/pom.xml 1204713 

Diff: https://reviews.apache.org/r/2902/diff


Testing
-------


Thanks,

Alejandro


                
> Pig POM brings in several unneeded dependencies
> -----------------------------------------------
>
>                 Key: OOZIE-607
>                 URL: https://issues.apache.org/jira/browse/OOZIE-607
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>
> Pig 0.9.0 brings many unneeded runtime dependencies (ie junit) and dependencies that should not be there (servlet API).
> I've opened a JIRA for Pig (PIG-2373) but in the mean time we should take care of it in Oozie's sharelib POM

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OOZIE-607) Pig POM brings in several unneeded dependencies

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OOZIE-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154684#comment-13154684 ] 

jiraposter@reviews.apache.org commented on OOZIE-607:
-----------------------------------------------------



bq.  On 2011-11-21 22:13:31, Virag Kothari wrote:
bq.  > /trunk/sharelib/pom.xml, line 79
bq.  > <https://reviews.apache.org/r/2902/diff/1/?file=59634#file59634line79>
bq.  >
bq.  >     Can you explain why the scope is changed from runtime to compile?
bq.  >     
bq.  >     These libraries are picked at run time when pig related test cases are executed.
bq.  >     They are not used during compilation.

you are correct, and the same goes for jline, guava & antlr.

uploading a new patch in a few mins.

Thxs.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2902/#review3407
-----------------------------------------------------------


On 2011-11-21 21:29:01, Alejandro Abdelnur wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2902/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-21 21:29:01)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Excluding unneeded Pig dependencies. (Pig testcases pass)
bq.  
bq.  
bq.  This addresses bug OOZIE-607.
bq.      https://issues.apache.org/jira/browse/OOZIE-607
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/pom.xml 1204713 
bq.    /trunk/sharelib/pom.xml 1204713 
bq.  
bq.  Diff: https://reviews.apache.org/r/2902/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Alejandro
bq.  
bq.


                
> Pig POM brings in several unneeded dependencies
> -----------------------------------------------
>
>                 Key: OOZIE-607
>                 URL: https://issues.apache.org/jira/browse/OOZIE-607
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>
> Pig 0.9.0 brings many unneeded runtime dependencies (ie junit) and dependencies that should not be there (servlet API).
> I've opened a JIRA for Pig (PIG-2373) but in the mean time we should take care of it in Oozie's sharelib POM

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (OOZIE-607) Pig POM brings in several unneeded dependencies

Posted by "Alejandro Abdelnur (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OOZIE-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alejandro Abdelnur resolved OOZIE-607.
--------------------------------------

    Resolution: Fixed
    
> Pig POM brings in several unneeded dependencies
> -----------------------------------------------
>
>                 Key: OOZIE-607
>                 URL: https://issues.apache.org/jira/browse/OOZIE-607
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>
> Pig 0.9.0 brings many unneeded runtime dependencies (ie junit) and dependencies that should not be there (servlet API).
> I've opened a JIRA for Pig (PIG-2373) but in the mean time we should take care of it in Oozie's sharelib POM

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OOZIE-607) Pig POM brings in several unneeded dependencies

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OOZIE-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154556#comment-13154556 ] 

jiraposter@reviews.apache.org commented on OOZIE-607:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2902/
-----------------------------------------------------------

Review request for oozie.


Summary
-------

Excluding unneeded Pig dependencies. (Pig testcases pass)


This addresses bug OOZIE-607.
    https://issues.apache.org/jira/browse/OOZIE-607


Diffs
-----

  /trunk/pom.xml 1204713 
  /trunk/sharelib/pom.xml 1204713 

Diff: https://reviews.apache.org/r/2902/diff


Testing
-------


Thanks,

Alejandro


                
> Pig POM brings in several unneeded dependencies
> -----------------------------------------------
>
>                 Key: OOZIE-607
>                 URL: https://issues.apache.org/jira/browse/OOZIE-607
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>
> Pig 0.9.0 brings many unneeded runtime dependencies (ie junit) and dependencies that should not be there (servlet API).
> I've opened a JIRA for Pig (PIG-2373) but in the mean time we should take care of it in Oozie's sharelib POM

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira