[GitHub] [guacamole-client] necouchman commented on a change in pull request #687: GUACAMOLE-1508: Add support for nesting .jar files within extensions.

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #687:
URL: https://github.com/apache/guacamole-client/pull/687#discussion_r789283663



##########
File path: guacamole/src/main/java/org/apache/guacamole/extension/Extension.java
##########
@@ -355,12 +356,18 @@
      * @param file
      *     The file to load as an extension.
      *
+     * @param temporaryFiles
+     *     A modifiable List that should be populated with all temporary files
+     *     created for this extension. These files should be deleted on
+     *     application shutdown in reverse order.
+     *
      * @throws GuacamoleException
      *     If the provided file is not a .jar file, does not contain the
      *     guac-manifest.json, or if guac-manifest.json is invalid and cannot
      *     be parsed.
      */
-    public Extension(final ClassLoader parent, final File file) throws GuacamoleException {
+    public Extension(final ClassLoader parent, final File file,
+            final List<File> temporaryFiles) throws GuacamoleException {

Review comment:
       Should there be a backward-compatible convenience method? Is this going to break older versions of extensions in whatever version of Guacamole (1.5.0?) gets this functionality?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org